Code Monkey home page Code Monkey logo

Comments (5)

J12934 avatar J12934 commented on June 13, 2024 1

Had a look at the code, had this falsely remember it is loading the entire file in memory.
Should hopefully be easy to change / fix it to avoid these issues alltogether.

I don't quit agree that making this configurable is the best fix for it. That would just be one additional thing people would need to tweak to ensure the systems works properly, I'd rather try to see if we can avoid the issue alltogether.

That being said, of course having the resources for the lurker be configurable should still be possible, just think we should ensure that the default is working properly, vene for large files.

from securecodebox.

Alon-Katz avatar Alon-Katz commented on June 13, 2024 1

Hi @J12934 , Yes seems like it resolved the issue, thank you !
I will close this :)

from securecodebox.

J12934 avatar J12934 commented on June 13, 2024

HI @Alon-Katz

Do you know how big the file is that it's trying to upload there?

The lurker should stream the upload and never load the complete file into memory, so I don't know where this would happen.
We been using the lurker with these resource limits for a ton of scans and never ran into this issues even when uploading some really big files.

from securecodebox.

Alon-Katz avatar Alon-Katz commented on June 13, 2024

Hi @J12934 , The file size was 20.6 MB, and the issue is reproduced each time.
I believe the best option here is to allow customization of the lurker resources.

from securecodebox.

J12934 avatar J12934 commented on June 13, 2024

Should be fixed with release v4.5.0 :)
Can you check if this resolves the issue for you?

from securecodebox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.