Comments (3)
I did the following at the end of the ObjectWrapper.cs GetOwnProperty method. As you can see I created a new class called DictionaryDescriptor because I couldn't get the ClrAccessDescriptor class working. I will try and create a PullRequest very soon.
// if no methods are found check if target is an IDictionary
if (typeof(IDictionary).IsAssignableFrom(type))
{
return new DictionaryDescriptor(Engine, propertyName, Target);
}
using System.Globalization;
using System.Reflection;
using Jint.Native;
namespace Jint.Runtime.Descriptors.Specialized
{
public sealed class DictionaryDescriptor : PropertyDescriptor
{
private readonly Engine _engine;
private readonly object _key;
private readonly object _item;
private readonly MethodInfo _getter;
private readonly MethodInfo _setter;
public DictionaryDescriptor(Engine engine, string key, object item)
{
_engine = engine;
_item = item;
_getter = item.GetType().GetMethod("get_Item", BindingFlags.Instance | BindingFlags.Public);
_setter = item.GetType().GetMethod("set_Item", BindingFlags.Instance | BindingFlags.Public);
_key = _engine.Options.GetTypeConverter().Convert(key, _getter.GetParameters()[0].ParameterType, CultureInfo.InvariantCulture);
Writable = true;
}
public override JsValue? Value
{
get
{
object[] parameters = { _key };
return JsValue.FromObject(_engine, _getter.Invoke(_item, parameters));
}
set
{
var defaultValue = _item.GetType().IsValueType ? System.Activator.CreateInstance(_item.GetType()) : null;
object[] parameters = { _key, value.HasValue ? value.Value.ToObject() : null };
_setter.Invoke(_item, parameters);
}
}
}
}
from jint.
Please create a PR a rename it to IndexDescriptor
. Even better if you can add some unit tests.
from jint.
Just added PR #56
from jint.
Related Issues (20)
- Tasks cannot be executed sequentially
- Max Statements and general recommendations for limits HOT 1
- JsonValue primitives HOT 1
- The type initializer for 'Jint.Native.Global.GlobalObject' threw an exception.
- Unexpected token using modules HOT 1
- Can no longer use cached Esprima Scripts HOT 1
- LocaleCompare encountered inconsistent results with the browser HOT 1
- NRE after upgrading to Jint 3.1.1 from 3.1.0 HOT 1
- URL API HOT 1
- Wrong Repo, sorry HOT 1
- Task<JsValue> is not correctly marshalled into JS code HOT 2
- Implicit Namespaces & Interopt HOT 4
- Addition-assignment -, subtract-assignment - and multiply-assignment operator throws an error when using BigInt HOT 2
- Incorrect C# code not throwing an exception HOT 1
- Engine.Execute fails when executing Array.map (d3.js) HOT 1
- System.NullReferenceException: Object reference not set to an instance of an object. HOT 5
- Setting private properties causes NRE HOT 6
- Is the tail-call feature really needed?
- Accessing dynamic objects returns incorrect type HOT 1
- reference.ReferencedName type is number but was string in older versions HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jint.