Code Monkey home page Code Monkey logo

Comments (7)

lahma avatar lahma commented on July 17, 2024 2

Now indexer selection knows how to prioritize better and latest issue should be covered by #1669

from jint.

lahma avatar lahma commented on July 17, 2024 1

Should be now fixed in main / soon available on MyGet feed.

from jint.

uleelx avatar uleelx commented on July 17, 2024

Should be now fixed in main / soon available on MyGet feed.

This issue remains in version 3.0.0-preview-506(Myget feed). @lahma

from jint.

lahma avatar lahma commented on July 17, 2024

Should be now fixed in main / soon available on MyGet feed.

This issue remains in version 3.0.0-preview-506(Myget feed). @lahma

The test case associated with the PR now passes and earlier it didn't resolve to integer indexer. Can you show a failing test case to diagnose?

from jint.

uleelx avatar uleelx commented on July 17, 2024

Should be now fixed in main / soon available on MyGet feed.

This issue remains in version 3.0.0-preview-506(Myget feed). @lahma

The test case associated with the PR now passes and earlier it didn't resolve to integer indexer. Can you show a failing test case to diagnose?

Just remove line 3300 of Jint.Tests/Runtime/InteropTests.cs:

        public interface IStringCollection : IIndexer<string>, ICountable<string>
        {
            string this[string name] { get; }
            string this[int index] { get; } // remove this line
        }

because interface "IStringCollection" inherits "IIndexer" which claims the integer indexer above.

from jint.

lahma avatar lahma commented on July 17, 2024

Inherited indexer that needs type coercion might be a limitation I'd be willing to accept, unless someone wants to submit a PR to improve the logic.

from jint.

uleelx avatar uleelx commented on July 17, 2024

Now indexer selection knows how to prioritize better and latest issue should be covered by #1669

Kudos to you for your exceptional PR! Your expertise and attention to detail are highly appreciated.

from jint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.