Comments (9)
public interface I0
{
string NameI0 { get => "I0.Name"; }
string OverloadSuperMethod() => "I0.OverloadSuperMethod()";
string SubPropertySuperMethod() => "I0.SubPropertySuperMethod()";
}
public interface I1 : I0
{
string Name { get; }
string OverloadSuperMethod(int x) => $"I1.OverloadSuperMethod(int {x})";
new string SubPropertySuperMethod => "I1.SubPropertySuperMethod";
}
[Fact]
public void CallSuperPropertyFromInterface()
{
Assert.Equal(holder.I1.NameI0, _engine.Evaluate("holder.I1.NameI0"));
}
[Fact]
public void CallOverloadSuperMethod()
{
Assert.Equal(holder.I1.OverloadSuperMethod(1), _engine.Evaluate("holder.I1.OverloadSuperMethod(1)"));
Assert.Equal(holder.I1.OverloadSuperMethod(), _engine.Evaluate("holder.I1.OverloadSuperMethod()"));
}
[Fact]
public void CallSubPropertySuperMethod()
{
Assert.Equal(holder.I1.SubPropertySuperMethod, _engine.Evaluate("holder.I1.SubPropertySuperMethod"));
// Property and method cannot coexist
Assert.Throws<Exception>(() => _engine.Evaluate("holder.I1.SubPropertySuperMethod()"));
}
You PR pass CallOverloadSuperMethod
but break CallSubPropertySuperMethod
.
IMO, we'd better refactor TypeResolver , take care of the search order.
And fill property cache when loaded, remove property lazyload.
from jint.
@Genteure 回复完 我愣了一下。。。我以为浏览器开了翻译。。原来你发的就是中文🤣
from jint.
You PR pass
CallOverloadSuperMethod
but breakCallSubPropertySuperMethod
.
How is the holder instantiated in your code?
IMO, we'd better refactor TypeResolver , take care of the search order. And fill property cache when loaded, remove property lazyload.
Yes I agree, suggest refactoring TryFindMemberAccessor
into replaceable logic ,Just like the MemberNameCreator
and the MemberNameComparer
😁
from jint.
I searched around in https://github.com/dotnetcore/FreeSql on GitHub (so not in an IDE) and I can't seem to find an implementation of ISelect0
. Can you tell me what's the concrete type of objSelect
in your initial example code please?
from jint.
@Genteure Here is a unit test in FreeSql
In my project ,my method will retrun a type of ISelect<object>
like this:
public ISelect<object> SelectTypedQuery(string typeName = default)
{
if (string.IsNullOrEmpty(typeName))
{
return FreeSql.Select<object>().AsType(typeof(ContentItemIndex));
}
var indexService = _serviceProvider.GetRequiredService<IDynamicIndexAppService>();
var type = indexService.GetDynamicIndexType(typeName);
if (type != null)
{
return FreeSql.Select<object>().AsType(type);
}
else
{
throw new Exception($"Type not found. : {typeName} ");
}
}
from jint.
@hyzx86 我是想问它的实际运行时的类型是什么,方便我确认一下现在的 unit test 是否能代表实际你遇到的问题。我对那个项目不熟悉,项目里面的抽象层又太多,我在 GitHub 上搜索代码找不到一个实现了 ISelect0
, ISelect1
的 concrete type。
objSelect.GetType().FullName
from jint.
@Genteure
With the help of @viruscamp , I have reproduced this problem using the code he provided.
from jint.
@hyzx86 我是想问它的实际运行时的类型是什么,方便我确认一下现在的 unit test 是否能代表实际你遇到的问题。我对那个项目不熟悉,项目里面的抽象层又太多,我在 GitHub 上搜索代码找不到一个实现了
ISelect0
,ISelect1
的 concrete type。objSelect.GetType().FullName
FreeSql.Sqlite.Curd.SqliteSelect`1[[System.Object, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]]
from jint.
@Genteure 就在这个链接下,有个单元测试,返回的东西跟我的测试应该是一样的
select 的类型是:
from jint.
Related Issues (20)
- Module resolution does not work for absolute path HOT 3
- 'Property 'Wait' of object is not a function' when calling .Wait() on a task with the usage of Jint 3.0.1 HOT 5
- System.InvalidOperationException: 'UnwrapIfPromise' called before Promise was settled HOT 1
- Readonly engine HOT 5
- Tasks cannot be executed sequentially
- Max Statements and general recommendations for limits HOT 1
- JsonValue primitives HOT 1
- The type initializer for 'Jint.Native.Global.GlobalObject' threw an exception.
- Unexpected token using modules HOT 1
- Can no longer use cached Esprima Scripts HOT 1
- LocaleCompare encountered inconsistent results with the browser HOT 1
- NRE after upgrading to Jint 3.1.1 from 3.1.0 HOT 1
- URL API HOT 1
- Wrong Repo, sorry HOT 1
- Task<JsValue> is not correctly marshalled into JS code HOT 2
- Implicit Namespaces & Interopt HOT 4
- Addition-assignment -, subtract-assignment - and multiply-assignment operator throws an error when using BigInt HOT 2
- Incorrect C# code not throwing an exception HOT 1
- Engine.Execute fails when executing Array.map (d3.js) HOT 1
- System.NullReferenceException: Object reference not set to an instance of an object. HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jint.