Code Monkey home page Code Monkey logo

Comments (6)

LiamRiddell avatar LiamRiddell commented on June 8, 2024 3

Personally, I believe we have a unique approach which we could really optimize and have a true native experience for MJML optimized compilation. While Rust is quick I believe if we start wrapping it and having to start sub processes or marshalling it could lead to another non-native solution.

I believe the best approach would be to continue our version (as we're nearly there in terms of the core subset of components) and see the performance. If the performance is way better, we could reach out to the rust project owner to re-implement our approach for even faster compilation.

I'm personally not a fan of wrappers, which hand off to another executable or loading unmanaged code.

from mjml-net.

SebastianStehle avatar SebastianStehle commented on June 8, 2024 1

Sounds good

from mjml-net.

SebastianStehle avatar SebastianStehle commented on June 8, 2024 1

Btw: I have tested a small wrapper and rust takes around 2.2ms for amario:

21.3506
2.0836
2.2084
2.0636
2.0526
2.3086
2.007
2.1208
1.9797
2.2234
2.0732
2.2368
2.1503
2.251
2.0719
2.2062
2.0711
2.3133
2.2634
2.5704

from mjml-net.

LiamRiddell avatar LiamRiddell commented on June 8, 2024 1

I'm currently running benchmarks for all the templates. I will be publishing to readme soon.

from mjml-net.

SebastianStehle avatar SebastianStehle commented on June 8, 2024 1

But it is not fair if we do not support all tags yet.

from mjml-net.

LiamRiddell avatar LiamRiddell commented on June 8, 2024 1

Yeah, I'm mainly doing it to extend the benchmarking project and once we're mostly feature complete before release we can run the benchmarks again.

from mjml-net.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.