Comments (4)
Hi,
$result->wasSuccessful()
currently focuses on pure backup execution. I admit this is somehow confusing.
The method you could use right now is $result->allOk()
Sadly the current version has a bug and is missing to validate some values.
From todays point of view this whole skip, fail, success mixing makes my head hurt and I should simplify this in the future.
This
46b8eb2
fixes the $result->allOk()
bug
But I think you are right, a failing check should fail the backup as well.
There's actually a test called
public function testBackupFailedOnFailedCheck()
from phpbu.
Fixed in version 3.0.1, once again thanks for reporting this.
from phpbu.
To make sure everything (backup, check, crypt, sync and cleanup) worked you still have to use $result->allOk()
The method $result->wasSuccessful()
is still limited to the backup and it's checks.
from phpbu.
You're too good! Thanks man :)
from phpbu.
Related Issues (20)
- Retry Uploads when one multipart failed HOT 3
- Call to undefined function JmesPath\mb_strlen() HOT 5
- Debug not allowed HOT 1
- CLI no restore guide HOT 5
- Add option to tar+ssh on a different host - Feature Request
- Add support for `zstd`
- PHP 8.1 generates a lot of warnings HOT 1
- Add --no-tablespaces for mysqldump
- FTP stepwise cleanup not working
- Incremental Backup TAR Compression Restore
- How to tar exclude relative to source directory? HOT 1
- Error backuping a big tar.gz to s3 HOT 1
- Yandex disk cleanup
- Please consider updating `https://phar.phpbu.de` HOT 1
- Please consider reinstating .phar downloads in releases HOT 1
- Broken emails sent by phpbu HOT 2
- excludeCollections in mongodb HOT 4
- PHP 8.2.9 PHP Fatal error: Uncaught Error: Class "Illuminate\Support\Collection" not found in phar HOT 1
- Self update of PHAR throws missing permission exception HOT 1
- exit-code: 137 message: /usr/bin/tar HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phpbu.