Comments (5)
Hi again! I think it might have something to do with how PACMAN is finding the trace. I had the same issue with TOI-1201, it seems to not be able to find the trace correctly for most targets in the 17192 program. I have trted changing cmin and cmax in the code, but that didn't change anything: the trace was still incorrect and the error was still present. I'm uploading an image of the trace as well.
from pacman.
Hi, I had a similar problem with a different data set and found a solution for which I put in a pull request. In my case the coordinate of the reference pixel ('CRPIX' in the file header) wasn't the same for the direct and the spectral images. To account for that, I had to modify the code for stage 10 where the offset is set. I just changed the variables 'LTV1' and LTV2' to:
LTV1 = ima[1].header['LTV1'] + int(abs(ima[1].header['CRPIX1'] - sp[1].header['CRPIX1']))
LTV2 = ima[1].header['LTV2'] + int(abs(ima[1].header['CRPIX1'] - sp[1].header['CRPIX1']))
For that to work you have to load one spectral image before:
files_sp = meta.files_sp # spectra files
sp = fits.open(files_sp[0]) # opens first spectral file
This than also modifies the cmin and cmax in stage 20 and I got the right trace position in the end.
Maybe this will work for your data too.
from pacman.
Hi @mar-palt ,
thanks for the issue! I've been trying to resolve your previous issue #21 and this one (#24) but I haven't been successful yet. But it looks like @n-bachmann found a solution!
I will test it on some datasets to see if it works.
In the meantime, you could try @n-bachmann 's fix and see if it helps.
from pacman.
Hi all,
Thank you for your responses! I tried @n-bachmann's solution and it worked! This is what my trace looks like at the moment.
The trace for TOI-1201 relating to issue #21 was also corrected, I will upload an image of the trace there. I'm still having an issue with Stage 30, however. When trying to perform either the white light curve or the spectroscopic light curve for TOI-561, I'm getting this error:
Could I have some help with this as well? Thank you!
from pacman.
Oh that's great!
Perfect! I will test it on some other datasets in the next few hours and update PACMAN to a new version.
@mar-palt , for the new fit problem you mentioned, could you create a new issue? This issue here will be closed after I merge the PR by @n-bachmann . In the new issue, please also attach your pcf and fit_par file. Thanks!
from pacman.
Related Issues (19)
- replace mpfit!!! HOT 1
- Issue with "no directory" when running s21 HOT 2
- more documentation needed for fit_par.txt parameters HOT 1
- Documentation is failing HOT 1
- limb_dark in fit_par.txt does not do anything HOT 2
- S30: How to specify the directory containing the exotic-LD data
- Fitting the Light Curves documentation: Model combination HOT 2
- Fitting the Light Curves documentation: Model calculation HOT 2
- Fixing limb darkening coefficients HOT 1
- Issue with TOI-1201 data optimal extraction HOT 13
- TOI-561 Stage 30 error HOT 5
- codecov does not work HOT 1
- AttributeError: 'FormatParams' object has no attribute 'per'
- Phase folded plot should check if user fits for transit or eclipse
- Stage 30 error: ValueError: Axis limits cannot be NaN or Inf
- Error when running Stage 30 in the Quickstart Tutorial HOT 3
- Error when running Stage 30 (spec) on my own data HOT 7
- Problem with trace in GRISM512 subarray HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pacman.