Code Monkey home page Code Monkey logo

Comments (5)

mar-palt avatar mar-palt commented on June 29, 2024

Hi again! I think it might have something to do with how PACMAN is finding the trace. I had the same issue with TOI-1201, it seems to not be able to find the trace correctly for most targets in the 17192 program. I have trted changing cmin and cmax in the code, but that didn't change anything: the trace was still incorrect and the error was still present. I'm uploading an image of the trace as well.

trace_0

from pacman.

n-bachmann avatar n-bachmann commented on June 29, 2024

Hi, I had a similar problem with a different data set and found a solution for which I put in a pull request. In my case the coordinate of the reference pixel ('CRPIX' in the file header) wasn't the same for the direct and the spectral images. To account for that, I had to modify the code for stage 10 where the offset is set. I just changed the variables 'LTV1' and LTV2' to:
LTV1 = ima[1].header['LTV1'] + int(abs(ima[1].header['CRPIX1'] - sp[1].header['CRPIX1']))
LTV2 = ima[1].header['LTV2'] + int(abs(ima[1].header['CRPIX1'] - sp[1].header['CRPIX1']))
For that to work you have to load one spectral image before:
files_sp = meta.files_sp # spectra files
sp = fits.open(files_sp[0]) # opens first spectral file
This than also modifies the cmin and cmax in stage 20 and I got the right trace position in the end.
Maybe this will work for your data too.

from pacman.

sebastian-zieba avatar sebastian-zieba commented on June 29, 2024

Hi @mar-palt ,
thanks for the issue! I've been trying to resolve your previous issue #21 and this one (#24) but I haven't been successful yet. But it looks like @n-bachmann found a solution!
I will test it on some datasets to see if it works.
In the meantime, you could try @n-bachmann 's fix and see if it helps.

from pacman.

mar-palt avatar mar-palt commented on June 29, 2024

Hi all,

Thank you for your responses! I tried @n-bachmann's solution and it worked! This is what my trace looks like at the moment.

trace_0

The trace for TOI-1201 relating to issue #21 was also corrected, I will upload an image of the trace there. I'm still having an issue with Stage 30, however. When trying to perform either the white light curve or the spectroscopic light curve for TOI-561, I'm getting this error:

Screen Shot 2023-11-21 at 12 27 04 PM

Could I have some help with this as well? Thank you!

from pacman.

sebastian-zieba avatar sebastian-zieba commented on June 29, 2024

Oh that's great!
Perfect! I will test it on some other datasets in the next few hours and update PACMAN to a new version.

@mar-palt , for the new fit problem you mentioned, could you create a new issue? This issue here will be closed after I merge the PR by @n-bachmann . In the new issue, please also attach your pcf and fit_par file. Thanks!

from pacman.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.