Comments (5)
Comment by havok2063
Thursday Jul 07, 2016 at 14:43 GMT
I'm fine with this as long as we leave the current versions of them in sdss_python_module for all the other code. At least until the point where I can migrate that code over to use Marvin instead.
Marvin still makes a new DatabaseConnection using sdss_python_module, so the dependency is not completely gone. We would need to refactor that a bit. Unless we bring all of that code over into Marvin then we will still have a dependency. Either on sdss_python_module or whatever product contains SDSSDbConnect (Totoro or some new thing).
from marvin.
Comment by albireox
Thursday Jul 07, 2016 at 19:32 GMT
I think there are two options here:
- Copy the SDSSDbConnect code here, and refactor it (always refactor) to serve our purposes.
- Add SDSSDbConnect as a submodule of Marvin (see here for submodules) so that we can use it as part of Marvin.
I like to keep things modular, but at some point it may just be simpler to consolidate everything in Marvin and be done with it.
from marvin.
Comment by havok2063
Thursday Jul 07, 2016 at 20:09 GMT
This sounds like something to be discussed and done during the Seattle MarvinWeek. We can probably rapidly refactor this when sitting next to each other. Presumably Totoro would then use the same submodule?
from marvin.
Comment by albireox
Thursday Jul 07, 2016 at 20:12 GMT
Yes, let's discuss this in Seattle. It should be easy to do once we get to an agreement.
Originally I used SDSSConnect as a submodule in Totoro, but it was a nightmare to keep things working with the SVN. That's something we should consider if we go with the submodule option.
from marvin.
Comment by albireox
Thursday Oct 06, 2016 at 19:19 GMT
This has already been done and is working. Marvin does not depend on sdss_python_module anymore (and the crowd goes wild).
from marvin.
Related Issues (20)
- Need help downloading emline maps HOT 3
- Error messages on jinja2, flask, json HOT 4
- packaging version > 22 breaks legacy version syntax HOT 6
- modelcube.stellarcont_fit raises an error HOT 1
- absmag_g_r column is incorrect
- json import error in itsdangerous package
- cannot import name 'safe_str_cmp' from 'werkzeug.security' HOT 2
- Integrated spectra of MaNGA galaxies HOT 2
- cannot import name 'escape' from 'jinja2' HOT 9
- package confliction
- Marvin Web No Longer Displaying Maps HOT 5
- Marvin not opening maps after pip install update HOT 1
- Internal Server error HOT 2
- cannot access maps HOT 6
- Cannot Query Full List of Parameters HOT 1
- BrainError for accessing data in remote mode HOT 1
- data release None no longer supported by the Marvin API HOT 2
- make the JHU marvin the default API endpoint
- Fix the test suite
- Failure to retrieve a Maps file given MaNGAID HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from marvin.