Code Monkey home page Code Monkey logo

Comments (1)

fredclausen avatar fredclausen commented on July 28, 2024

I really like this. Some immediate thoughts:

  • It would be really annoying to have it bump the minor version 4-5 times if we had a lot of cargo packages updated with dependabot PRs. I've used a workflow on ACARS Hub (https://github.com/sdr-enthusiasts/docker-acarshub/blob/main/.github/workflows/combine_prs.yml) that will combine PRs from dependabot. It doesn't really work all that well in ACARS Hub because dependabot PRs tend to fail on the on_pr build because of an auth/push issue I've never bothered to figure out so the workflow is never run, but that is a specific problem with that repo. We shouldn't have that issue here, and having one PR and one version bump seems ideal.
  • For PRs we generate that would require a patch / major bump that seems less obvious how it would "just work" (but could also be my caffeination state at the moment....), but I assume it's an issue we would be able to work around.

In an ideal world I would love the CI to generate a PRs from dependabot, build, verify they pass the cargo test and any other tests we have, merge in with a minor version bump, and then build a new release, completely automatically.

Right now while we verify functionality and iterate the code base to be robust we should not do auto merges, but that's where I feel we should end up.

from acars_router.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.