Comparison functions raise exceptions about pendulum HOT 5 CLOSED

I just released the 0.6.1 version that fixes the issue.

from pendulum.

Thanks for reporting this.

There are two sides to this issue:

• First, the possible comparison between Pendulum instances and strings or integer. This is an idea that will create problems more than it will solve any.
• Second, comparison methods do not catch ValueError exceptions.

Anyway, the best approach for this is to catch the ValueError exceptions and return NotImplemented since if an exception is raised it means that other is not compatible.

I will push a fix and it should land officially in the next bugfix release next week.

from pendulum.

Good to hear. I feel ashamed for these 3 references btw. Close your eyes.

from pendulum.

Don't worry :-)

The idea was there anyway and it would have worked, so no need to feel ashamed.

from pendulum.

Commit 1: I commited my .python-version file.
Commit 2: somehow it inserted 3 spaces instead of 4.

I feel like I had to say that. GitHub should make these references like they are in PRs, which I thought they were. Lesson learned I guess: "Don't reference issues in commit messages."

On a side note regarding #48, I have implemented Period.exclude along with the previous methods. You could always use these in case you want to implement these here. But you said you wanted to do it only for one? Period._exclude does it only for one period, but still returns a list of periods.

from pendulum.