Seastar httpd incorrectly handles HTTP 0.9 requests about seastar HOT 4 OPEN

In terms of priority it shouldn't be urgent. We first need to make sure
memcache is awesome

On Wed, Oct 29, 2014 at 10:11 AM, nyh [email protected] wrote:

If you do

telnet www.google.com 80
GET /

You'll immediately be sent the response. This is the trivial HTTP 0.9
protocol, where the HTTP/.. version isn't specified on the GET line, and
the server does not wait for any headers in the request, beyond the URL.

Unfortunately Seastar's httpd does not handle this case correctly, and
seems to just hang after getting the "GET /" line. Not even another input
line, even an empty line suggesting the end of headers, appear to finish
this hang.

—
Reply to this email directly or view it on GitHub
#6.

from seastar.

Fixed by b0b36c2

from seastar.

Avi, unfortunately, this bug is not fixed (the different issue, #3, is fixed).
As I explained above, if you do

telnet 192.168.122.2 10000
GET /

What you'll see is nothing. What you should see, is the response, immediately. Without even waiting for another newline (HTTP 0.9 did not have request headers).

This is not an urgent bug - usually HTTP 0.9 will only be used in debugging sessions, not by real-life browsers - and our httpd isn't mission critical - but it is nevertheless still a bug, and should not be closed. Avi, can you please reopen it? I don't have the permissions, apparently :-(

from seastar.

I verified that this problem still exists today. It's still as non-interesting as it was (no real browser will use HTTP 0.9 - note that HTTP 1.0 is already 21 years old), but still a bug 😉

from seastar.