reserved identifier violation about seastar HOT 2 CLOSED

On Tue, Apr 28, 2015 at 3:24 PM, Markus Elfring [email protected]
wrote:

I would like to point out that identifiers like "_APP_TEMPLATE_HH
https://github.com/cloudius-systems/seastar/blob/5bc8d7cfadb78caf37b47e1bd351852c52de04d1/core/app-template.hh#L21"
and "_MEMCACHED_HH
https://github.com/cloudius-systems/seastar/blob/5bc8d7cfadb78caf37b47e1bd351852c52de04d1/apps/memcached/memcached.hh#L18"
do not fit
https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29
to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?

My personal preference is just to use "#pragma once", and we do use it in
quite a few header files.

"#pragma once" isn't standard C++, but all the compilers I tried seem to
support it well, and it's (in my opinion) much less ugly and error-prone
than those include guards.

from seastar.

This is fixed as of 61c905c.

from seastar.