Provide methods in Request class to set connection and read timeouts about scribejava HOT 7 CLOSED

Now that you mention it... yeah, I don't know what happened when I was coding that... :P

Is it absolutely necessary to support both timeouts? wouldn't the connect timeout just do?

Thanks!

from scribejava.

I need the read timeout because I'm processing a persistent stream of data via getInputStream() for a long duration. In case the connection is dropped, the read timeout is necessary so that an IOException is thrown. The connection timeout is only useful for the initial connection.

from scribejava.

Ok.

planned for 1.0.8

from scribejava.

Great thanks! Let me know if you want me to make this change so you can pull/merge.

from scribejava.

Yes that would be awesome.

Just note the 2 spaces for indent and the K&R braces.

Thanks!

from scribejava.

I just sent you a pull request for this. Let me know when 1.0.8 is available!

from scribejava.

Merged, I just changed the signature to this:

setConnectTimeout(int duration, TimeUnit unit)

so you can set the timeout both in seconds and millis.

from scribejava.