Comments (6)
Shay,
Working on it right now
from scribejava.
Thanks!
If you're interested, what I did, is just made sure it's a valid URI rather than URL, and that fixed everything I needed.
Great package by the way! :)
Shay
from scribejava.
Cool.
What I changed is this:
Let me know what you think about it
from scribejava.
Looks cool...
I did
static boolean isUrl(String url)
{
try {
new URI(url);
} catch (URISyntaxException e) {
return false;
}
return true;
// return url.startsWith("http://") || url.startsWith("https://");
}
I'm not sure performance wise what is better, regex or using try/catch, but I think both will work equally good, and since it's only once per service, it's not that bad anyway.
Thanks again
from scribejava.
Cool.
I kinda have a weakness for regexes, and don't like the try catch blocks a lot so I think I'll leave as it is for now...
You have the fix on 1.0.4 released just now.
sorry for the delay I've been working my ass of lately :)
from scribejava.
I know your point of view... I love regexes as well...
Anyway, thanks! I'll let you know if I find more things in the package....
btw - are you thinking about integrating with OAuth 2.0 ? (What Facebook is using...), it's almost the same as OAuth 1, but with some minor changes
from scribejava.
Related Issues (20)
- Device authorization codes request should include client_secret
- Use better default Accept-header for JDKHttpClient
- scribejava-core dependency on jackson-databind affected by CVE-2020-36518 HOT 2
- BoxApi20 can't obtain access_token
- Unmaintained? HOT 2
- LinkedIn API v2 access-/refresh-token new rules header Content-Type: x-www-form-urlencoded HOT 3
- I want to know how to get the code automatically HOT 1
- How to build a Oauth2 server use scribejava HOT 1
- Example using streaming HOT 1
- PKCE example uses "clientSecret" HOT 1
- Device Flow HOT 1
- File payloads not working (for Linkedin)
- Linkedin: Migrate to versioned APIs HOT 1
- Support for OAuth2 Adobe developer console
- Add Zendesk Oauth 2.0 Support
- OAuth 1.0 Trello issue HOT 1
- Requests are not processed and can see them stuck in requestQueue HOT 2
- How to use with Retrofit
- oauth_timestamp missing or invalid (suggestion for improvement with code)
- KeycloakApi doesn't work with Keycloak version >= 17
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scribejava.