Code Monkey home page Code Monkey logo

Comments (4)

abebus avatar abebus commented on June 15, 2024 1

Thanks, didn't know crawler can automatically await on async functions connected via signals. The following code works as expected:

import asyncio
import logging
from scrapy import signals
import aiohttp

class AsynctestPipeline:
    async def ainit(self):
        logging.critical('async init')
        self.client = aiohttp.ClientSession()
        self.something = await self.client.get('https://scrapy.org/')
        logging.critical('async initialised')

    async def adel(self):
        logging.critical('async closing resources')
        await self.client.close()
        logging.critical('async resources closed')

    @classmethod
    def from_crawler(cls, crawler):
        p = cls()
        crawler.signals.connect(p.ainit, signal=signals.spider_opened)
        crawler.signals.connect(p.adel, signal=signals.spider_closed)
        return p
        

    async def process_item(self, item, spider):
        logging.critical('executing async task')
        await asyncio.sleep(10)
        logging.critical('async task done')
        logging.critical(self.something)
        return item

from scrapy.

Gallaecio avatar Gallaecio commented on June 15, 2024

Only process item has coroutine support. Try using the spider_closed signal instead.

from scrapy.

abebus avatar abebus commented on June 15, 2024

but why then open_spider works?

from scrapy.

Gallaecio avatar Gallaecio commented on June 15, 2024

My guess: both work, only that the spider closes before the close one gets executed. Do you get any mentions in the standard output about unawaited futures? If you add a long sleep on the close spider signal, the close one might work. In any case, it is not intended to work in open_spider either, so I strongly suggest not to do that either, there is also an spider_open signal.

from scrapy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.