Code Monkey home page Code Monkey logo

Comments (5)

fumieval avatar fumieval commented on May 23, 2024 1

if you raiseStatus 308 "/foo/bar" you get redirected.

No please don't do this, because "/foo/bar" is not a response body but a location header (I assume that's your intent). It would be very strange to change the semantics of the second argument depending on the value of the status code.

I think the right direction is to get rid of raiseStatus altogether, and encourage users to use either finish or a user-defined exception

from scotty.

ocramz avatar ocramz commented on May 23, 2024

one problem with deprecating raiseStatus is that we use it internally when a request body is too large.

from scotty.

fumieval avatar fumieval commented on May 23, 2024

IMO calling raiseStatus from scotty should be avoided because it makes it harder to customise the response. How about making ScottyException more semantic, providing a default handler in place of statusErrorHandler? For example it could be data ScottyException = RequestTooLarge | MalformedJSON |...

This way, by setting defaultHandlers users are able to customise the handling of these exceptions

from scotty.

ocramz avatar ocramz commented on May 23, 2024

from scotty.

fumieval avatar fumieval commented on May 23, 2024

Sure. I'll submit a PR in the coming days

from scotty.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.