Code Monkey home page Code Monkey logo

Comments (4)

stefanv avatar stefanv commented on August 27, 2024

How about using the GitHub PR number?

from procbuild.

mpacer avatar mpacer commented on August 27, 2024

We could use the PR number, but then it'd be better to iterate over a dictionary, which then can't guarantee the order.

I tried the reversal approach in #27 and it seems like it works.

from procbuild.

mpacer avatar mpacer commented on August 27, 2024

So I think that we should switch it to use a dict based lookup based on the PR number, but that's a bigger change than the reversal for now, so we should make that a new issue if/when we close this one.

Reasoning being: dict based indexing is a more robust system, but, technically, a nice-to-have.

from procbuild.

stefanv avatar stefanv commented on August 27, 2024

Agreed, those IDs are better.

from procbuild.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.