Code Monkey home page Code Monkey logo

Comments (12)

rschwarz avatar rschwarz commented on June 8, 2024

What does it mean to support the new SCIP, can't we support both?

Does any of the code of CSIP change because of that? If so, then we require the user to install the new SCIP, which I feel is a breaking change, so we should go to 0.4.0.

from csip.

fserra avatar fserra commented on June 8, 2024

Well, there is a single line of code changed in CSIP.

I guess we could support both, but why?

from csip.

rschwarz avatar rschwarz commented on June 8, 2024

Then the update is not a breaking change, and people who update SCIP.jl with Julia's package manager don't end up with a broken system.

On the other hand, users would not even know about the new SCIP...

@mlubin : Do you have an opinion on this?

from csip.

fserra avatar fserra commented on June 8, 2024

it is not a breaking change, but it will just not compile with SCIP 3.2.1, or am I missing your point?

from csip.

rschwarz avatar rschwarz commented on June 8, 2024

Yes, so an update of SCIP.jl will tell them that CSIP is out-of-date, but if the user then deletes CSIP (as instructed) and runs Pkg.build("SCIP") it will fail.

from csip.

fserra avatar fserra commented on June 8, 2024

why will it fail? scip 4 is out now ;)

from csip.

rschwarz avatar rschwarz commented on June 8, 2024

Users still have to download and install it, nothing is automated.

from csip.

fserra avatar fserra commented on June 8, 2024

yeah, but that has always been then case, right?

from csip.

mlubin avatar mlubin commented on June 8, 2024

Given that everything is already manual, it's okay with me if an update to SCIP.jl results in a broken system. However, it would be nice to provide a useful error message, e.g., as we do with ECOS. Whoever wants to keep using the old version of SCIP can pin SCIP.jl.

from csip.

rschwarz avatar rschwarz commented on June 8, 2024

Well, we have that error message in SCIP.jl, but refering to CSIP, not SCIP.

@fserra: Didn't you already have a pull request with a one-line change? We should then also update the README and be explicit about SCIP's version.

from csip.

fserra avatar fserra commented on June 8, 2024

yeah sure. So what is it then? 0.4.0 or 0.3.7??

from csip.

rschwarz avatar rschwarz commented on June 8, 2024

Go for 0.4.0.

from csip.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.