Code Monkey home page Code Monkey logo

Comments (2)

YingboMa avatar YingboMa commented on June 2, 2024

StructuralIdentifiability.jl/src/util.jl

Lines 284 to 309 in f872f19

e = ModelingToolkit.Symbolics.value(e)
return eval_at_nemo(e, vals)
end
function eval_at_nemo(e, vals::Dict)
if ModelingToolkit.Symbolics.istree(e)
args = map(a -> eval_at_nemo(a, vals), ModelingToolkit.Symbolics.arguments(e))
if ModelingToolkit.Symbolics.operation(e) in [+, -, *]
return ModelingToolkit.Symbolics.operation(e)(args...)
elseif isequal(ModelingToolkit.Symbolics.operation(e), /)
return //(args...)
end
if ModelingToolkit.Symbolics.operation(e) === ^
if args[2] >= 0
return args[1]^args[2]
end
return 1 // args[1]^(-args[2])
end
throw(Base.ArgumentError("Function $(ModelingToolkit.Symbolics.operation(e)) is not supported"))
end
end
function eval_at_nemo(e::Union{ModelingToolkit.Symbolics.Sym,ModelingToolkit.Symbolics.Term}, vals::Dict)
if typeof(e) <: ModelingToolkit.Symbolics.Term{Real,Nothing}
throw(Base.ArgumentError("Function $(ModelingToolkit.Symbolics.operation(e)) is not supported"))
end

Not having an explicit compat for Symbolics or SymbolicUtils but depend on its internals isn't a good idea. StructuralIdentifiability.jl will be broken if MTK makes a new release.

As a side note

ModelingToolkit.Symbolics.operation(e) in [+, -, *]

allocates a vector every time. You probably want (+, -, *).

from structuralidentifiability.jl.

pogudingleb avatar pogudingleb commented on June 2, 2024

Thanks for the suggestion! We will fix this as well

from structuralidentifiability.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.