Bug in basen.py about category_encoders HOT 3 CLOSED

Seems like it, that's weird. Col2 appears to work fine, but col1 is both wrong and for some reason a float. Can you post the underlying ordinal encoder mapping?

from category_encoders.

@wdm0006

[{'col': 'col1', 'mapping': [('a', 0), ('b', 1), ('c', 2)]}, {'col': 'col2', 'mapping': [('d', 0), ('e', 1), ('f', 2)]}]
   col1_0  col1_1  col2_0  col2_1
0     0.0     0.0       0       0
1     0.0     1.0       0       1
2     0.0     0.0       1       0

I think bug is in the function def basen_encode(self, X_in, cols=None) in basen.py
https://github.com/scikit-learn-contrib/categorical-encoding/blob/56d01334de5b1c45f5ddb600f587c86bfa67d9c0/category_encoders/basen.py#L238

from category_encoders.

Yeah, the ordinal mapping looks fine, I'll have to take a closer look at BaseN and write some tests for this example when I get a chance. Thanks for the heads up.

from category_encoders.