H&E and Residual, rather than HED about scikit-image HOT 5 OPEN

Hi @mkcor,

Sorry for my late response. Sure, I can provide an implementation on rgb2her and her2rgb function. Since I'm new to skimage development, is there any format guidance for me (as well as the docs guidance)? If @GParolini is available, we would pretty much like to start the implementation or I just start it for now and see if @GParolini wants to join.

from scikit-image.

Hi @OswaldZhang,

After reading you and re-reading the old related issues, I'm sold, we should have and rgb2her (and, conversely, her2rgb) function, in order to handle H&E (Hematoxylin + Eosin) images. Would you be able to start a pull request with an implementation for rgb2her and, perhaps, collaborate with @GParolini (who posted #7334 (comment))? Or vice-versa?

from scikit-image.

Thanks for the kindly guidance @mkcor and glad to hear from you @GParolini. I've DM you through Zulip, let's kick it off!

from scikit-image.

Hi @OswaldZhang,

Wonderful! I believe that @GParolini should be available in May.

Please follow these instructions to get started with contributing to scikit-image.

To write your rgb2her and her2rgb functions, you would edit the skimage/color/colorconv.py file. Follow the style and format used in the other conversion functions there, e.g.,

Then, you would add tests in skimage/color/tests/test_colorconv.py (following the style and format used in the other tests there).

Should you need any help, please poke us in the chat or in the developer forum.

from scikit-image.

Hi @OswaldZhang, I would be happy to work together on this issue. We can discuss in Zulip or in the developer forum how to proceed.

from scikit-image.