Code Monkey home page Code Monkey logo

Comments (7)

maxnoe avatar maxnoe commented on June 11, 2024 4

I don't know if it makes sense to use uproot in root_pandas and not directly start contributing to uproot.TTree.pandas at this already implements much functionality of root_pandas.

e.g:

import uproot

f = uproot.open('file.root')
tree = f['tree']

df = tree.pandas.df()

from root_pandas.

jonas-eschle avatar jonas-eschle commented on June 11, 2024

Sounds good, but are you aware that root_numpy is considering using uproot as their backend? If they use it, I think it is better to just build on top of their implementation and not trying to implement the same thing at two different places.

Would there be any additional benefit in skipping root_numpy and directly invoking uproot (if root_numpy has the option to use uproot as their backend)

from root_pandas.

alexpearce avatar alexpearce commented on June 11, 2024

I wasn't aware. But absolutely, if root_numpy will already take care of the fallback behaviour then there's no need for root_pandas to implement it.

from root_pandas.

beojan avatar beojan commented on June 11, 2024

There doesn't seem to have been any change in root_numpy on this matter.

from root_pandas.

alexpearce avatar alexpearce commented on June 11, 2024

Indeed! But I think the functionality belongs more naturally in root_numpy, so scikit-hep/root_numpy#250 would be a better place to check the status.

from root_pandas.

eduardo-rodrigues avatar eduardo-rodrigues commented on June 11, 2024

@chrisburr, I won't close this task without your OK … but I would simply close it at this stage, and having in mind the developments in uproot.

from root_pandas.

eduardo-rodrigues avatar eduardo-rodrigues commented on June 11, 2024

No need to write down here all reasons but this can safely be closed at this stage given all community discussions and developments in the last 3 years.

from root_pandas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.