Comments (5)
@russelljjarvis
This is supposed to be taken care of automatically by the fact that (at least in scidash/dev
) all core types now inherit from sciunit.SciUnit
, which creates an unpicklable
attribute in its constructor. If this is working, then why do we also need a picklable
attribute as well? Shouldn't everything that is not unpicklable be picklable?
from neuronunit.
Sorry yes, it was supposed to read:
if not hasattr(score,'unpicklable'):
score.unpicklable = []
I must have been tired when writing it.
I can confirm that the lines:
class SciUnit(object):
"""Abstract base class for models, tests, and scores."""
def __init__(self):
self.unpicklable = [] # Attributes that cannot or should n
are still in sciunit, note that this seems to satisfy all of the tests in the suite besides class RheobaseTest(VmTest)
, which is the only test to contain score type of scores.RatioScore
. I am unsure why it fails for scores.RatioScore but not the other score types. Looking into this now.
from neuronunit.
I think if I add unpicklable = []
as an attribute to the SciUnit class, not just create it in the constructor, then any subclass instance should have that attribute even if somehow the constructor never got called. I think the constructor isn't getting called because you are somehow putting instances of tests into test suites with attributes that were not fully realized by the usual route.
from neuronunit.
Done in scidash/sciunit@e6f7009. Check to see if this works for you know, @russelljjarvis.
from neuronunit.
I think this is fixed or obsolete with the new Backend implementation.
from neuronunit.
Related Issues (20)
- newer test class for passive elephant tests breaks parallelism in dask, in the case of brian2 backend. HOT 4
- Documenting all Score edge cases that break optimization gradients HOT 3
- A document Notice to debug set PARALLEL_CONFIDENT=False
- Test Suites should be dictionaries not lists. HOT 7
- Use standardized units throughout
- Sciunit judge no longer works with static Models. How can I opt of using the ProtocolToFeaturesTest? HOT 8
- Druckmann Tests are not proper tests
- Confirm that NeuronUnits jNeuromLB backend really can be regarded as a ground truth. HOT 7
- NU test.protocol should be flat or more predictable to traverse.
- Major NU interface redesigns could come with interface diagrams.
- documentation chapters of NeuronUnit should be upgraded to Unit Tests via pytest-ipynb
- 2.5 different code locations that determine sim_length need to be collapsed into one.
- Duplicated content injected current test protocol/parameter
- Installation Fails on Windows HOT 1
- create branch optimization based on dev, that I can merge pull requests into. HOT 2
- Migrate away from travis HOT 2
- Merge error in backend __init__.py HOT 2
- Missing closing ' HOT 1
- Relax constraints on install requirements HOT 1
- unresolved merge conflict in requirements.txt
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from neuronunit.