I am confused. I am sure it didn't work this way before but I am not able to track thi

The problem is caused by function: <div class="snippet-clipboard-content notransla

Pressing STOP during milling causes damage to material and drill about candle2 HOT 3 CLOSED

schildkroet commented on May 26, 2024

Pressing STOP during milling causes damage to material and drill

from candle2.

Comments (3)

Schildkroet commented on May 26, 2024

That's a "feature" of Candle.
I also noticed the behaviour sometimes, but didn't have time to analyze it yet.

from candle2.

czapeczek commented on May 26, 2024

The problem is caused by function:

void frmMain::restoreOffsets()
{
    // Still have pre-reset working position
    sendCommand(QString("G21G53G90X%1Y%2Z%3").arg(toMetric(ui->txtMPosX->text().toDouble()))
                                       .arg(toMetric(ui->txtMPosY->text().toDouble()))
                                       .arg(toMetric(ui->txtMPosZ->text().toDouble())), -1, m_settings->showUICommands());

sendCommand(QString("G21G92X%1Y%2Z%3").arg(toMetric(ui->txtWPosX->value()))
                                       .arg(toMetric(ui->txtWPosY->value()))
                                       .arg(toMetric(ui->txtWPosZ->value())), -1, m_settings->showUICommands());
}

in frmmain.cpp
It's ok to just comment those commands but it would be good to understand the intention why there are there. This function is used only twice in code, but really only once depending on the protocol used.

For now I can just comment that and make a pull request, just let me know

from candle2.

Schildkroet commented on May 26, 2024

I decided to comment the function call out. Restoring the offset, after you press STOP seems unnecessary and is dangerously.
Thanks for you help

from candle2.

Recommend Projects