Incorrect colors in ViewRenderable about sceneform-android HOT 2 CLOSED

As I understand the inverseTonemapSRGB does two things. It converts the color from the sRGB space to the linear space and applies the inverse transformation to cancel the tone-mapping effect. The problem can be solved by converting the color manually as described in the FIlament materials guide: https://google.github.io/filament/Materials.html#handlingcolors/linearcolors. I will ask about that because I am not sure about the performance impact.

from sceneform-android.

Hi @grassydragon,

You are totally right about it.
Actually I put it in the TODO list since I was not completely sure about the ViewRenderable inverseTonemapSRGB original usage reason.
I already removed it elsewhere (in the Renderable class from what I can remember) without issues (also from what I can remember).
I actually try not to spend too much time on the Sceneform little bug fixes and focus more on the new framework publication date.

But it would be very helpful for anyone using Sceneform if you could ask the Filament team about the reason why inverseTonemapSRGB could have been used. Link the question to this issue and make a quick PR.

Thanks a lot for your great report !

from sceneform-android.