Comments (4)
I dug a little into this: For Scala 2.13.10 in the ticket mentioned above, scoverage wasn't released yet. That has been resolved with scoverage 2.0.5. That helps us a bit but brings up another issue: scoverage 2.x+ is a new major version that doesn't support Scala 2.11.x anymore. So we have three options:
- Drop support for Scala 2.11.x (fine for me, nothing should block users to update to Scala 2.12.x)
- Drop coverage from our CI (fine for me as well, as long as we demand tests for new inspections)
- Have some if-else in sbt to use a different scoverage version for Scala 2.11.x than for 2.12+
Irregardless, for scoverage 2.x we would need to add a library dependency scheme to ignore the conflict in scala-xml that raises an error otherwise because version 2.x+ of scala-xml is used in the newer scoverage whereas we use 1.3.0 for Scala 2.11.x. Like this:
// sbt-scoverage plugin depends on scala-xml 2.x.x which is not available for Scala 2.11.x
libraryDependencySchemes += "org.scala-lang.modules" %% "scala-xml" % "always"
Your thoughts?
from scapegoat.
Maybe @sksamuel has an opinion?
from scapegoat.
It seems dropping Scala 2.11 makes life easier for everyone, most likely people who stuck with 2.11 can't upgrade things much anyway
Just my 2c
from scapegoat.
from scapegoat.
Related Issues (20)
- Support for 2.13.8 HOT 1
- New inspection level - SKIP HOT 3
- Issues when releasing 1.4.12 / 1.4.13 HOT 5
- Support for 2.13.9 HOT 2
- Add "hacktoberfest" topic HOT 1
- Please release 1.4.17 for scala 2.12.17 HOT 3
- New Inspection: Avoid `require`
- please compile for scala 2.13.11 HOT 2
- `UnnecessaryConversionTest` failing in latest Scala community build HOT 2
- mvn compile build failure InterfaceCompileFailed HOT 3
- Support Gitlab / Clodeclimate report format HOT 3
- Scala 2.13.12 HOT 1
- Support Actionable Diagnostics from Scala 2.13.12+ HOT 2
- Using Cons bypasses Option.Get violation HOT 2
- Suport for Scala 2.13.13
- Support Scala 2.13.14
- SwallowedException when exception is logged and custom exception is rethrown HOT 1
- Run sbt ci-release failure HOT 13
- Install the Codecov GitHub app HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scapegoat.