Code Monkey home page Code Monkey logo

Comments (10)

Mahgozar avatar Mahgozar commented on June 24, 2024

i did a little more tinkering the problem seems to be with my .excalidraw files that are interpreted as really really really big text files
and because of that they make the whole thing fall apart is there anyway to fix this?
perhaps a way to exclude a certain folder path from indexing?

from obsidian-omnisearch.

Mahgozar avatar Mahgozar commented on June 24, 2024

upon more testing the problem seems to be with JavaScript heap out of memory
image
but the problem is that when i run obsidian using a higher maximum i can't get it to go beyond 4g for some reason it just doesn't listen
image

from obsidian-omnisearch.

scambier avatar scambier commented on June 24, 2024

I'll add a setting to make indexing of excalidraw files an opt-in, as a quick fix.

And increasing memory limit in Electron seems to be quite fiddly, if not straight up impossible if you can't build yourself :/
electron/electron#2056

from obsidian-omnisearch.

Mahgozar avatar Mahgozar commented on June 24, 2024

yeah i've been googling all over the past 6 hours :)))) couldn't find a thing, thank you for the response

from obsidian-omnisearch.

Mahgozar avatar Mahgozar commented on June 24, 2024

just an idea, can we change anything in that .asar file of obsidian to perhaps make this work differently? i have very limited programming knowledge so i have no idea if this even makes sense

from obsidian-omnisearch.

scambier avatar scambier commented on June 24, 2024

If you update Omnisearch, I added a (hidden) setting excalidrawIndexing. You can modify it in yourvault\.obsidian\plugins\omnisearch\data.json. If you can confirm it "solves" the freeze at startup I'll add a toggle in the settings page 👍

from obsidian-omnisearch.

Mahgozar avatar Mahgozar commented on June 24, 2024

unfortunately the same problem still very much exists
image
image
image

from obsidian-omnisearch.

scambier avatar scambier commented on June 24, 2024

Ok so the crash happening while indexing an excalidraw file was just a coincidence. It's possible that your vault is somehow too large for Omnisearch; or actually, Omnisearch's RAM consumption during indexing is too high for Electron.

Could you try this test build? I've reduced the size of batches during indexing, and added pauses between each batch to (hopefully) let the GC do its thing. omnisearch_1.20.4-bugfix.334.1.zip.

You can extract the files right next to the data.json you previously edited.

from obsidian-omnisearch.

Moyf avatar Moyf commented on June 24, 2024

I'm not sure if our problem is same, but when enabling Omnisearch, my OB would stuck for seconds.
The console shows:
image

Is this normal?
I have 'bout 700+ md files, and 3000 files at all.

from obsidian-omnisearch.

scambier avatar scambier commented on June 24, 2024

Is this normal? I have 'bout 700+ md files, and 3000 files at all.

Not the same problem, as it looks like Omnisearch is correctly indexing your files. If you have a large cache, it can indeed freeze Obsidian for a few second while all the data is processed and loaded in memory.

from obsidian-omnisearch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.