Code Monkey home page Code Monkey logo

Comments (5)

GollyTicker avatar GollyTicker commented on September 26, 2024 1

Interesting. When I get to it, I'll test this with debug console in my setup and also sprinkle some logs inbetween. The second notification definitively should't occur in my case except if I'm doing something nonstandard somewhere. Thanks for the hint. ๐Ÿ˜„

from obsidian-omnisearch.

scambier avatar scambier commented on September 26, 2024

The notification is supposed to be shown only when there's >= 1000 updated files. Does it work differently for you?

(also I think you can just tap on the notification to make it disappear, fwiw)

from obsidian-omnisearch.

GollyTicker avatar GollyTicker commented on September 26, 2024

Interesting. I get these notifications quite frequently. At least the "omnisearch finished indexing" comes altmost everytime.

I am aware, that I can tap on it - but I'd prefer it not just come in the first place. Sometimes, I might get distracted when I start typing and the notification comes only a second or two after I started.

As I said. I'm willing to implement it myself since I don't expect it to be too hard...

from obsidian-omnisearch.

scambier avatar scambier commented on September 26, 2024

Start indexing:

if (diff.toAdd.length >= 1000 && isCacheEnabled()) {
new Notice(
`Omnisearch - ${diff.toAdd.length} files need to be indexed. Obsidian may experience stutters and freezes during the process`,
10_000
)
}

End indexing:

if (diff.toAdd.length >= 1000 && isCacheEnabled()) {
new Notice(`Omnisearch - Your files have been indexed.`)
}

In both cases, those notifications (should) appear when there's more than 1000 modified/added files. I guess we could reduce the duration for the first notification, but I won't disable them ๐Ÿคทโ€โ™‚๏ธ

from obsidian-omnisearch.

scambier avatar scambier commented on September 26, 2024

Closing this issue, feel free to reopen if you have more information to share.

To summarize, if the notification appears, that means Omnisearch effectively sees at least 1000 modified files and has to reindex them. Even if only the timestamp is different and those files are virtually identical, the reindex will have to be done, so the notification is warranted.

from obsidian-omnisearch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.