Add a normal task with no arguments about scalastyle-sbt-plugin HOT 3 OPEN

Thanks for your input. I agree that we can change things to make this easier, and I think your idea of having a normal input task is a good one, and would cover the bases. Now all we have to do is think of a good name: how about scalastyleTask

from scalastyle-sbt-plugin.

My comment saying that we "first call the compile task" is a bit misleading since we are not really calling it, sbt will figure out the order for us. There is also an unused scalastyleTask argument which if it was used would not work since then the order is not defined. It works in this case but only because it calls doScalastyle directly. This is all a little bit silly.

I went to the sbt docs to go and lookup Defining a sequential task with Def.sequential and low and behold the example is exactly what we want. Keeping in mind that it should be a "raw task" so that users can choose the configuration to use (for reference Provide raw settings and configured settings).

As for the name, that is a hard one. I would say that it should probably start with compile. The most descriptive would be something like compileThenCheckStyle.

In terms of completeness I would be inclined to do something like:

1. Add a val scalastyleDefaultArgs = Setting[Seq[String]] for the default args which defaults to Seq.empty
2. A non-input task that does something like scalastyleWithDefaultArgs := scalastyle.toTask(scalastyleDefaultArgs.mkString(" ")).value
3. A raw task for compiling and checking the style compileThenCheckStyle := Def.sequential(compile, scalastyleWithDefaultArgs).value

If I remember this later I'll double check that it works and submit a PR.

from scalastyle-sbt-plugin.

@steinybot this would be really helpful!

from scalastyle-sbt-plugin.