Fail to send `didFocusTextDocument` in Sublime 4 about metals-sublime HOT 8 CLOSED

If I remember correctly the difficulty on the LSP package side is about keeping track of diagnostics for files that aren't open. @jvican I recommend you create an issue on the LSP package so that we can discuss this issue and possible solutions there.

As for the didFocusTextDocument notification just ping me for a review.

from metals-sublime.

I fixed this, will make a PR, but the diagnostics issue is still happening. @rwols Do you know what might be going on? I think the LSP server is sending the diagnostics and Sublime is not showing them because the file is not open. Is that possible?

from metals-sublime.

Thanks for for the fix @jvican.

As for the other issue, from my understanding it is a limitation of the LSP package on which this package rely. @rwols Is there an existing issue on the LSP repo ?

from metals-sublime.

Thanks for the answer. Now that you say it, it makes sense it's a problem on the LSP package. I think this is quite a severe limitation because it gives the impression that the changes the user is doing in the editor are OK when they are really not. Delaying or hiding diagnostics for other messages ends up getting in the way of my workflow. @rwols Would it be possible to get a fix for that in the plugin? How much would it take?

from metals-sublime.

Exactly what’s the problem?

from metals-sublime.

Oh the diagnostics. Yeah, we only show diags for open files. I don’t have any plans to change this, but we’re always open to pull requests.

from metals-sublime.

I will do that, will elaborate on why this is important for languages such as Scala.

from metals-sublime.

The underlying pain described in this issue has been fixed in sublimelsp/LSP#1868 (comment) and it will be released soon.

from metals-sublime.