Code Monkey home page Code Monkey logo

Comments (2)

ekrich avatar ekrich commented on May 23, 2024

Very nice analysis 😄

from scala-native.

LeeTibbert avatar LeeTibbert commented on May 23, 2024

Could someone who knows Windows check this out?

I believe that WindowsDosFileAttributeView.scala is using reference equality rather than content equality.

The relevant code is (edited for presentation):

       class DosFileKey(volumeId: DWord, fileIndex: ULargeInteger)

        private val dosFileKey =
          new DosFileKey(
            volumeId = fileInfo.volumeSerialNumber,
            fileIndex = fileInfo.fileIndex
          )


     
	def fileKey(): Object = dosFileKey  // Object equals is, I believe, reference equality.

~~ I believe the simplest fix is to use a case class class DosFileKey(volumeId: DWord, fileIndex: ULargeInteger).
That should generate equals & hashcode methods which override those in Object to give content equality.~~

In the unix code, I decided to override equals(), hashCode(), and toString()

from scala-native.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.