Code Monkey home page Code Monkey logo

Comments (2)

jschlyter avatar jschlyter commented on June 14, 2024 1

And thanks for keeping me honest - never report a bug without a PR is a golden rule! :-)

from aiomqtt.

frederikaalund avatar frederikaalund commented on June 14, 2024

Hi Jakob, thanks for raising this issue. Let me have a look. :)

I think you're right. The following is an excerpt from paho-mqtt:

    def on_connect(self, func):
        """ Define the connect callback implementation.
        Expected signature for MQTT v3.1 and v3.1.1 is:
            connect_callback(client, userdata, flags, rc, properties=None)
        and for MQTT v5.0:
            connect_callback(client, userdata, flags, reasonCode, properties)
        client:     the client instance for this callback
        userdata:   the private user data as set in Client() or userdata_set()
        flags:      response flags sent by the broker
        rc:         the connection result
        reasonCode: the MQTT v5.0 reason code: an instance of the ReasonCode class.
                    ReasonCode may be compared to interger.

The connect callback gets:

  • an int for MQTT v3.1 and V3.1.1
  • a ReasonCode for MQTT v5.0

We should update the types to reflect this. Do you want to submit a pull request?

Note that ReasonCode is comparable to int.

from aiomqtt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.