requst for enhancement : paho.mqtt.proxy_set() - support about aiomqtt HOT 4 CLOSED

Excellent! I'd gladly review the PR on that. Good job on the other PR btw. 👍

from aiomqtt.

Thank you so much :) Okay I will work on it and create a pull request.

from aiomqtt.

Thanks for opening this issue. Let me have a look. :)

asyncio-mqtt SHOULD make provisions to utilize paho.mqtt.client.proxy_set(**proxy_args)

You're absolutely right, set_proxy is not currently in asyncio-mqtt and, yes, we should include it.

( honestly, i wont pull because i think code-change is @maintainer ;-) )

It is a simple addition and you're welcome to make a pull request to add it. 👍
I suggest we follow the API design of the will feature. I.e.:

• Create a ProxySettings class that holds all proxy arguments.
• Add proxy as a keyword argument to the Client: Client.__init__(self, ..., proxy: Optional[ProxySettings] = None)

from aiomqtt.

I can look into this and create a pull request for this as well. Do you think I should go ahead with it?

from aiomqtt.