steps Set -Dsbt.boot.directory=&lt

Sbt doesn't propagate `SBT_OPTS` to the generated bsp config,about sbt/sbt

adpi2 commented on June 18, 2024

Thanks for the report!

I don't expect the SBT_OPTS to be propagated to the BSP config. However the server should read the SBT_OPTS when started by the BSP command. It is a bug if it does not.

from sbt.

kasiaMarek commented on June 18, 2024

However the server should read the SBT_OPTS when started by the BSP command. It is a bug if it does not.

That seems to work as expected.

I don't expect the SBT_OPTS to be propagated to the BSP config.

Is there a different way to add -Dsbt.boot.directory=<some_path> option to the bsp config permanently ? The trouble is that if you add it manually, sbt seems to regenerate the config quite a lot, and the option disappears.

from sbt.

adpi2 commented on June 18, 2024

Is there a different way to add -Dsbt.boot.directory=<some_path> option to the bsp config permanently ?

No I don't think it is currently possible without a fix in sbt itself.

My suggestion would be to change the way sbt generates the BSP config. It should generate .../sbt -bsp instead of .../java ... xsbt.boot.Boot -bsp. That would solve your issue because the sbt script does read the SBT_OPTS env.

It would solve other issues like:

it does not start with the current Java version in the path
it does not use the native sbt client

from sbt.

kasiaMarek commented on June 18, 2024

My suggestion would be to change the way sbt generates the BSP config.

How should we generate the config then? We generate it running .../sbt bspConfig wouldn't that be the preferred way?

from sbt.

adpi2 commented on June 18, 2024

We generate it running .../sbt bspConfig wouldn't that be the preferred way?

Yes it is.

I am suggesting to change the implementation of sbt bspConfig in sbt. The code is here:

sbt/protocol/src/main/scala/sbt/internal/bsp/BuildServerConnection.scala

Lines 26 to 61 in 48c2376

    
           private[sbt] def writeConnectionFile(sbtVersion: String, baseDir: File): Unit = { 
        
             val bspConnectionFile = new File(baseDir, ".bsp/sbt.json") 
        
             val javaHome = System.getProperty("java.home") 
        
             val classPath = System.getProperty("java.class.path") 
        
             val sbtScript = Option(System.getProperty("sbt.script")) 
        
               .orElse(sbtScriptInPath) 
        
               .map(script => s"-Dsbt.script=$script") 
        
             // IntelliJ can start sbt even if the sbt script is not accessible from $PATH. 
        
             // To do so it uses its own bundled sbt-launch.jar. 
        
             // In that case, we must pass the path of the sbt-launch.jar to the BSP connection 
        
             // so that the server can be started. 
        
             // A known problem in that situation is that the .sbtopts and .jvmopts are not loaded. 
        
             val sbtLaunchJar = classPath 
        
               .split(File.pathSeparator) 
        
               .find(jar => SbtLaunchJar.findFirstIn(jar).nonEmpty) 
        
               .map(_.replace(" ", "%20")) 
        
               .map(jar => s"--sbt-launch-jar=$jar") 
        
             val argv = 
        
               Vector( 
        
                 s"$javaHome/bin/java", 
        
                 "-Xms100m", 
        
                 "-Xmx100m", 
        
                 "-classpath", 
        
                 classPath, 
        
               ) ++ 
        
                 sbtScript ++ 
        
                 Vector("xsbt.boot.Boot", "-bsp") ++ 
        
                 (if (sbtScript.isEmpty) sbtLaunchJar else None) 
        
             val details = BspConnectionDetails(name, sbtVersion, bspVersion, languages, argv) 
        
             val json = Converter.toJson(details).get 
        
             IO.write(bspConnectionFile, CompactPrinter(json), append = false) 
        
           }

from sbt.

kasiaMarek commented on June 18, 2024

Oh, yeah, sorry. I misread what you wrote.

from sbt.

Sbt doesn't propagate `SBT_OPTS` to the generated bsp config about sbt HOT 6 OPEN

Comments (6)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	private[sbt] def writeConnectionFile(sbtVersion: String, baseDir: File): Unit = {
	val bspConnectionFile = new File(baseDir, ".bsp/sbt.json")
	val javaHome = System.getProperty("java.home")
	val classPath = System.getProperty("java.class.path")

	val sbtScript = Option(System.getProperty("sbt.script"))
	.orElse(sbtScriptInPath)
	.map(script => s"-Dsbt.script=$script")

	// IntelliJ can start sbt even if the sbt script is not accessible from $PATH.
	// To do so it uses its own bundled sbt-launch.jar.
	// In that case, we must pass the path of the sbt-launch.jar to the BSP connection
	// so that the server can be started.
	// A known problem in that situation is that the .sbtopts and .jvmopts are not loaded.
	val sbtLaunchJar = classPath
	.split(File.pathSeparator)
	.find(jar => SbtLaunchJar.findFirstIn(jar).nonEmpty)
	.map(_.replace(" ", "%20"))
	.map(jar => s"--sbt-launch-jar=$jar")

	val argv =
	Vector(
	s"$javaHome/bin/java",
	"-Xms100m",
	"-Xmx100m",
	"-classpath",
	classPath,
	) ++
	sbtScript ++
	Vector("xsbt.boot.Boot", "-bsp") ++
	(if (sbtScript.isEmpty) sbtLaunchJar else None)

	val details = BspConnectionDetails(name, sbtVersion, bspVersion, languages, argv)
	val json = Converter.toJson(details).get
	IO.write(bspConnectionFile, CompactPrinter(json), append = false)
	}