Code Monkey home page Code Monkey logo

Comments (5)

steinybot avatar steinybot commented on September 4, 2024

I may have found a workaround:

lazy val sbtProject = (project in file("sbt"))
  .dependsOn(core)
  .enablePlugins(SbtPlugin)
  .settings(commonProjectSettings)
  .settings(
    skip := {
      CrossVersion.partialVersion((core / scalaVersion).value) match {
        case Some((2, n)) if n == 13 => true
        case _ => false
      }
    },
    crossScalaVersions := Nil,
  )

from sbt-github-actions.

steinybot avatar steinybot commented on September 4, 2024

Well that didn't work.

Latest iteration is:

import explicitdeps.ExplicitDepsPlugin
import explicitdeps.ExplicitDepsPlugin.autoImport._
import sbt.Keys._
import sbt._
import sbt.plugins.SbtPlugin

// This is all the crazy hacks to get cross compiling working with an sub-project that is an sbt plugin.
object SbtSubProjectPluginPlugin extends AutoPlugin {

  override def trigger: PluginTrigger = allRequirements
  override def requires: Plugins      = ExplicitDepsPlugin && SbtPlugin

  private val sspppIsScala213 = settingKey[Boolean]("Checks if the current Scala version is 2.13")

  override def projectSettings: Seq[Def.Setting[_]] =
    List(
      crossScalaVersions := Nil,
      libraryDependencies := libraryDependenciesSetting.value,
      projectDependencies := projectDependenciesTask.value,
      sspppIsScala213 := {
        if (isScala213(scalaVersion.value))
          throw new IllegalStateException("sbt project must not use Scala 2.13. Did you force the version with '+'?")
        isScala213Setting.value
      },
      // We can't skip this as it has to run at least once or sbt complains.
      update / skip := false,
      // Skip everything else otherwise it will just fail.
      skip := sspppIsScala213.value,
      undeclaredCompileDependenciesFilter -= moduleFilter()
    )

  private def isScala213Setting = Def.setting {
    val versions =
      scalaVersion.all(ScopeFilter(inDependencies(ThisProject, transitive = true, includeRoot = false))).value
    versions.exists(isScala213)
  }

  private def isScala213(version: String) =
    CrossVersion.partialVersion(version) match {
      case Some((2, n)) if n == 13 => true
      case _                       => false
    }

  private def projectDependenciesTask = Def.task {
    // Remove all project dependencies for Scala 2.13 as they will not resolve when cross building.
    if (sspppIsScala213.value) {
      Seq.empty
    } else {
      projectDependencies.value
    }
  }

  private def libraryDependenciesSetting = Def.setting {
    // Remove all library dependencies for Scala 2.13 as they will not resolve when cross building.
    if (sspppIsScala213.value) {
      Seq.empty
    } else {
      libraryDependencies.value
    }
  }
}

from sbt-github-actions.

kubukoz avatar kubukoz commented on September 4, 2024

@steinybot just out of curiosity, what would happen if you set crossScalaVersions in ThisBuild to the whole set of versions, but with specific overrides in each project?

from sbt-github-actions.

steinybot avatar steinybot commented on September 4, 2024

That doesn't seem to make a difference. For the record the problem I have actually has nothing to do with sbt-github-actions instead it is sbt/sbt#5586.

from sbt-github-actions.

djspiewak avatar djspiewak commented on September 4, 2024

Yeah this is a serious limitation of sbt right now. There are a lot of crazy hacks to get around it but none of them work well. It's also something that you somewhat-forcibly hit whenever you have Scala Native in your build.

from sbt-github-actions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.