Comments (5)
One of my projects just can't be built without Java 14 since it uses JEP-370 API.
@djspiewak can you please explain the point of pinning of publish
job to [email protected]
? I just can't figure it out, seems like I'm missing something.
from sbt-github-actions.
There probably isn't a good reason for it. :-) I think the right thing to do is probably pin the publish job to the head of the JVMs list. I'll PR that quickly.
from sbt-github-actions.
Fixed in 0.6.2!
from sbt-github-actions.
There probably isn't a good reason for it. :-) I think the right thing to do is probably pin the publish job to the head of the JVMs list. I'll PR that quickly.
But won't the download step fail if the publish job doesn't use the exact same version as the build job?
As per my screenshots, the publish job and the build job use the java version for the URLs they fetch/save assets to (respectively), thus if they differ, the publish job will fail.
the right thing to do is probably pin the publish job to the head of the JVMs list
Isn't the right thing to make the publish job use the same version as the build job instead?
Having said this, I can see my publish job is now using the same version as what I've specified for the build, so seems to work 🤷♂️ 😄
Thanks!
from sbt-github-actions.
Isn't the right thing to make the publish job use the same version as the build job instead?
Well, the problem is that you can build with multiple JVMs (easy example: JDK 8 and JDK 11, but Graal also qualifies). You only want the publish job to run once, so we have to pick a JVM to use. The good news is that, as long as all of the build JVMs uploaded their artifacts, the publish job can use any one of them and it's fine. The only exception would be if you build different artifacts on different JVM versions and need them all to publish under some sort of version classifier scheme. I'm not aware of anyone who is actually doing something like that though (it would be really hard to correctly resolve such artifacts in downstream projects), so I feel pretty comfy declaring it "out of scope". :-)
from sbt-github-actions.
Related Issues (20)
- Prepare sbt-github-actions for release under sbt org HOT 13
- "Integration with sbt-ci-release" generates cross build HOT 3
- Remove sbt's strict JDK 1.8 check or publish using JDK 1.8?
- Add scalafmt code formatter HOT 2
- Pull request can trigger two workflow runs HOT 4
- Put sbt-github-actions into the `sbt` package HOT 1
- Use `SizeParser` to correctly parse and validate `windows.PageFileFix` fields
- Provide an interface to job level settings
- Please make a release! HOT 5
- Supporing JDK 20 with GraalVM >22 HOT 2
- Use Scala major versions rather than patch for generated actions HOT 1
- clean.yml doesn't respect githubWorkflowOSes HOT 11
- exposing base directory for monorepo support HOT 11
- Transfer copyright ownership from Daniel Spiewak to Scala Center? HOT 2
- Support Corretto JVM HOT 1
- upload-artifact/v4 not supported on GHES HOT 2
- Support `working-directory` in steps
- Problems with sbt-projectmatrix - upload artifact should be more granular
- Feature request: Add support for automatically labelling PRs by Github Actions
- macos-latest no longer has `sbt` installed by default HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sbt-github-actions.