Comments (4)
It's important to realize that the provided 'absolute' and 'relative' values are not tolerances, but levels at which your results will be judged. It is a common practice to set the tolerances for your particular simulator at 10x or even 100x smaller than the 'absolute' or 'relative' values.
However, I'm not sure even with this caveat why you're having a problem with this model. If you're within 100x smaller of the tolerances of the given values, that means that at (say) time point 2.3, the value of S1 should be 0.100259. Shortly thereafter, the event will fire. If your event is firing before time point 2.3, that's a clear problem with your simulator, since 0.1002 is still 20x the relative tolerance (0.0001) greater than 0.1. If it's firing after time point 2.4, that's a similarly odd problem, as it should have reached a value well below 0.1 by that time (it would be 0.09 or so).
I'm more than willing to adjust the test if the tolerances are really out of wack, but my own suspicion is that this is indicating a problem either in the tolerance settings, or in the simulator itself. This test has been in the SBML Test Suite since its inception, and to my knowledge, no other simulator has had any issues with it.
If time points 24 and 47 are the only time points that vary from the expected results, this is also confusing to me, as I would expect errors at those time points to propogate to future time points: both S1 and S2 change smoothly in time when not being changed by events. Having the event fire at a time sufficiently off from expected would under normal circumstances cause all affected variables to display a corresponding shift in value from expected.
Original comment by: luciansmith
from sbml-test-suite.
Okay that explains my problems. I passed the two values as absolute and relative tolerances to the solver. If I use more restrictive tolerances the problems disappears.
Original comment by: ffroehlich
from sbml-test-suite.
- status: open --> closed
- assigned_to: Lucian Smith
Original comment by: luciansmith
from sbml-test-suite.
Excellent! Glad to hear it. I've added a task to make this more clear in the documentation.
Original comment by: luciansmith
from sbml-test-suite.
Related Issues (20)
- Add scrollbar to process output window
- Don't offer number of threads option if wrapper does not support parallelism
- Change location where test runner gets updated test cases
- Fix broken image link in testsuite-ui README file HOT 1
- Test Runner sometimes crashes on empty case directories
- Test Runner crashes when changing Level and Version (and test results exists) HOT 8
- Remove the SBML L1V2 models with negative stoichiometry HOT 1
- Leading whitespaces in results.csv HOT 4
- Missing Tests for Models with Variables with SId `INF` or `NaN` HOT 7
- Test Runner crash with params named 'Time'. HOT 14
- SBMLTestRunner crashes on start-up with "Empty wrapper selection" HOT 3
- Accessing the test suite SBML models without cloning repository HOT 14
- Adjust test runner when 'time' is an output.
- test case where parameters have units HOT 1
- Test Runner: correctly sort and display oddly-capitalized data HOT 1
- Interpretation of case 48 HOT 3
- Meaning of `Xref` in case 974 HOT 11
- Incorrect l3v1 references
- tests with compartment volume assignments HOT 3
- Can't run this app on MacOS(M2 Ventura 13.2.1). HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sbml-test-suite.