Code Monkey home page Code Monkey logo

Comments (7)

drnextgis avatar drnextgis commented on August 23, 2024 1

Original issue was fixed in GDAL couple of hours ago: OSGeo/gdal@f7c27a8. It is possible to use the similar approach for calculating max factor value: if we already have a 1x1 overview then don't create a new one.

from telluric.

guydou avatar guydou commented on August 23, 2024

It is the overview code,
disable the overviews and it works:

rr.save('demo.tif', overviews=False)

the problem is the factor calculation

https://github.com/satellogic/telluric/blob/master/telluric/georaster.py#L565

if we create overview only upto factor 32, then the code will pass.

How can we know if the factors make sense?

from telluric.

drnextgis avatar drnextgis commented on August 23, 2024

We can introduce maximum width or height of the smallest overview level like it has been done in recent GDAL (minsize option of gdaladdo).

from telluric.

astrojuanlu avatar astrojuanlu commented on August 23, 2024

Thanks @drnextgis! I guess a fix will be released as part of GDAL 2.3.1, or 2.4.0 at most? In any case we should support older versions as well, so perhaps we should do as you say:

We can introduce maximum width or height of the smallest overview level like it has been done in recent GDAL (minsize option of gdaladdo).

from telluric.

astrojuanlu avatar astrojuanlu commented on August 23, 2024

Also, thanks for reporting this upstream: rasterio/rasterio#1333

from telluric.

drnextgis avatar drnextgis commented on August 23, 2024

@Juanlu001 what do you think the best place to fix this issue: here or directly in Rasterio?

from telluric.

astrojuanlu avatar astrojuanlu commented on August 23, 2024

@drnextgis The rasterio developers have labeled the issue as post-1.0, so I think it would be positive if we have a workaround in place ourselves. But I will leave this issue as good first issue, for potential contributors.

from telluric.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.