New Rule: Duplicate Property about sass-lint HOT 6 CLOSED

Will take a look at this one today.

from sass-lint.

Any opinions on whether this should trigger when using both long hand and short hand properties?

Should the following trigger an error?

.foo {
  margin-left: 10px;
  padding: 0;
  margin: 0;
}

from sass-lint.

I reckon it should because you are technically duplicating it there it's just sort of hidden from you, in that instance your margin-left value is being overwritten?

margin: {
  margin-top: 0,
  margin-right: 0,
  margin-bottom: 0,
  margin-left: 0
}

from sass-lint.

I've checked out the way SCSS Lint works, and they don't cause an error as technically they are different properties. Maybe this could be a different rule?

property-overwrite or something similar ? Thoughts?

from sass-lint.

Makes sense to me, maybe that would actaully be preferable so we can keep the rules fairly granular.

from sass-lint.

Since this is only ever disallowing (as you wouldn't ever be enforcing duplicate properties), I think it should follow the current convention for 'disallows' and call it no-duplicate-property

from sass-lint.