Code Monkey home page Code Monkey logo

Comments (5)

qodesmith avatar qodesmith commented on August 28, 2024 2

@SassNinja Just noticed that csswring is deprecated. This plugin uses that for the minimize option. Would you be open to a PR that changes to using cssnano instead?

from postcss-extract-media-query.

SassNinja avatar SassNinja commented on August 28, 2024 1

@qodesmith thanks for the offer!

however this has become obsolete since v2 because the minimize option has been removed

from postcss-extract-media-query.

SassNinja avatar SassNinja commented on August 28, 2024

did someone tried to create correct sourcemaps after the extraction?

not supported yet
it's quite challenging to implement because I think it depends on the build tool and to support all is not trivial

what build tool do you use?

is it possible to run cssnano to minify all extracted files directly without any temporary folder?

at the moment not possible because the minimization is hard coded in the plugin but I've plans to change this with the next major release (v2) and support any other postcss plugin.

but I haven't had time to work on this plugin

from postcss-extract-media-query.

SassNinja avatar SassNinja commented on August 28, 2024

@kingmauri I've finally found some time to take (partially) care of your feature requests

and my 2nd question is: is it possible to run cssnano to minify all extracted files directly without any temporary folder? there is an option for that i know, but cssnano do a lot more than just minify.

yes, since v2 (released a minute ago) it's possible to use whatever you like for minification as I parse the postcss.config.js and apply all subsequent PostCSS plugins to the extracted CSS as well

did someone tried to create correct sourcemaps after the extraction?

I've tried hard to also add source map support in v2.0.0 but it's really complicated because there are inconsistencies across the build tools (gulp behaves different to e.g. webpack) and I haven't found a way yet to always access the map within my plugin.

For more information you may follow this discussion postcss/postcss#1312

from postcss-extract-media-query.

mgrsskls avatar mgrsskls commented on August 28, 2024

Hi @SassNinja,

first of all thanks for the nice plugin! :)

Did you get by any chance get any further with generating source maps?

Thanks!

from postcss-extract-media-query.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.