Code Monkey home page Code Monkey logo

Comments (3)

ljharb avatar ljharb commented on July 19, 2024 1

I.e. [...new Set(arr)]

from eslint-find-rules.

ta2edchimp avatar ta2edchimp commented on July 19, 2024

First of all, thanks for providing that repo as a test case!

Strange thing is: the getRules method exposed by ESLint includes rules of plugins on ESLint ^3.121), but does not on ESLint ^4.0. So we duplicate the plugins' rules on ESLint ^3.12 when concatenating only pluginsRules and (what we think are only) coreRules.

This means, we have to get rid of the plugins' rules erroneously (?) included in the getRules methods response, when running using ESLint ^3.12.

We could exclude every item from coreRules that matches ^[^\/]+\/ (starting at least one character not being a slash, followed by a slash) or that is included in pluginRules (using our array-diff utility function).
Additionally we could do this only when require('eslint').linter.version matches ^3.12 according to semver, which I would definitely prefer.


  1. This only happens within the context of eslint-find-rules. When only running the Node repl, requireing ESLint and calling getRules, the plugins' rules are not included.
    Like this
    console.log(Array.from(require('eslint').linter.getRules().keys()).join('\n'));

from eslint-find-rules.

ljharb avatar ljharb commented on July 19, 2024

Seems like just deduping unconditionally makes the most sense?

from eslint-find-rules.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.