--no-error still outputs errors about eslint-find-rules HOT 13 CLOSED

Suppressing a non zero exit code would be achieved using --no-error.

Returning with a non zero exit code / an error code when there are unused rules, is legacy behavior to ensure all available rules are covered (to be used in a commit hook, for example), optionally suppressed.

from eslint-find-rules.

I wouldn't call it legacy behavior; that's the primary purpose of the binary.

from eslint-find-rules.

Yeah, sorry, bad wording choice (non native english speaker).

from eslint-find-rules.

Sorry, I meant to say that --no-error is not working.
-n works for me, but --no-error does not.

from eslint-find-rules.

I guess hyphenated options have a problem, probably will make it noerror.

from eslint-find-rules.

Tests only cover shorthand options. Same for --all-available.

from eslint-find-rules.

-no-error works for me.
--no-error does not.

from eslint-find-rules.

We just merged #196, but semantic release errored out. I will release the next version manually.
--no-error should work then.

from eslint-find-rules.

@mvolkmann can you try --no-error with the latest 1.14.1

from eslint-find-rules.

Looks like it's not quite fixed.

The command that was run was:
eslint-find-rules --unused ~/.eslintrc --no-error

I got this:
npm ERR! Failed at the [email protected] efr script 'eslint-find-rules --unused
~/.eslintrc --no-error'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the ui-lib package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! eslint-find-rules --unused ~/.eslintrc --no-error

$ npm info eslint-find-rules version
1.14.1

On Sat, Oct 29, 2016 at 5:57 PM, Sarbbottam Bandyopadhyay <
[email protected]> wrote:

@mvolkmann https://github.com/mvolkmann can you try --no-error with the
latest 1.14.1 https://www.npmjs.com/package/eslint-find-rules

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#194 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAE10Dr8MkrZxPSrRxr-1NUEE3qiYEdMks5q489cgaJpZM4KkKvX
.

R. Mark Volkmann
Object Computing, Inc.

from eslint-find-rules.

@mvolkmann I could not reproduce the latest problem you stated.
Steps followed.

• mkdir test-eslint-find-rules
• cd $_
• npm init --yes
• npm i eslint eslint-find-rules -D
• touch .eslintrc
• update .eslintrc with

{
  "rules": {
    "foo-rule": [2]
  }
}

• eslint-find-rules -u --no-error .eslintrc

No error found as per @mvolkmann last comment.

However, the exit status was 1 instead of 0. Thus reopening the issue.
#199 should resolve the issue.

from eslint-find-rules.

@mvolkmann could you try with 1.14.3 and let us know.

from eslint-find-rules.

That works! Thanks!

On Mon, Oct 31, 2016 at 12:09 AM, Sarbbottam Bandyopadhyay <
[email protected]> wrote:

@mvolkmann https://github.com/mvolkmann could you try with 1.14.3
https://www.npmjs.com/package/eslint-find-rules and let us know.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#194 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAE10GajjO8oFii0areq1RdZWEPK7LD0ks5q5Xf0gaJpZM4KkKvX
.

R. Mark Volkmann
Object Computing, Inc.

from eslint-find-rules.