Code Monkey home page Code Monkey logo

Comments (8)

ljharb avatar ljharb commented on July 19, 2024 1

I think that if you want the recommended set to only list the rules it's enabling, that perhaps that's a change that should be made upstream in eslint itself?

from eslint-find-rules.

ljharb avatar ljharb commented on July 19, 2024

"used" means precisely that - "defined". It's not "--enabled".

I think a new flag that finds rules that aren't enabled would be great! However, that's an entirely separate flag than --unused - otherwise you'd be breaking the existing use case of locating rules that aren't defined in the eslint config.

from eslint-find-rules.

wolfgang42 avatar wolfgang42 commented on July 19, 2024

No, I completely understand that 'unused' is different from 'enabled'. I think the problem is that I expected eslint:recommended to only define the list of recommended rules, in the same way that for example eslint-config-standard only lists the rules it's enabling, rather than listing out every possible eslint rule.

My specific use case is writing an eslint config that's based off the recommended list with a lot of extra rules added. Right now I'm commenting out the extends line, running eslint-find-rules, and manually removing all of the recommended rules from the list.

Basically, what I'm looking for is something like eslint-find-rules --unused --no-extends .eslintrc.yaml minus eslint-find-rules --enabled --only-extends .eslintrc.yaml

Hopefully that makes sense? Now that I look closer at the eslint API I'm not even sure if it's possible to do this, but it's kind of hard for me to tell without diving in and having a go at it.

from eslint-find-rules.

ta2edchimp avatar ta2edchimp commented on July 19, 2024

It will eventually be possible, once getRules() is exposed by ESLint's API (see #172 and issues linked within).

from eslint-find-rules.

IanVS avatar IanVS commented on July 19, 2024

@jfmengels did you open an issue upstream? I couldn't find one. Seems like a reasonable request to me, and I'm in the same boat as you trying to find unused rules.

Edit: @jfmengels just thumbs-up'ed it. Didn't scroll back up far enough to see that @wolfgang42 was the one who opened originally.

from eslint-find-rules.

jfmengels avatar jfmengels commented on July 19, 2024

No, I haven't. I could probably in a few days (a bit busy lately), but go ahead if you feel like it in the meantime.

from eslint-find-rules.

alexilyaev avatar alexilyaev commented on July 19, 2024

@ta2edchimp Are you guys considering this?

from eslint-find-rules.

ta2edchimp avatar ta2edchimp commented on July 19, 2024

Definitely.

But as I do not have the perfect idea about how to approach this, I'd recommend to use eslint-diff-rules in verbose mode as a workaround in the meanwhile:

eslint-diff-rules [your own config] ./node_modles/eslint/conf/eslint-recommended.js -v

from eslint-find-rules.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.