Code Monkey home page Code Monkey logo

Comments (6)

marcusholl avatar marcusholl commented on August 29, 2024

Cannot confirm that behavior. I have only one travis job triggered. See e.g. here.

I'm not an expert for the .travis.yml, but I can't see two configured jobs in that file (I'm even not sure if more than one job can be configured ...)

Right now we have a switch depending on ${TRAVIS_PULL_REQUEST} in our build. But that is not used for preventing builds to start, it only controls what happens inside the - already started - build. Would be possible to use an if: trigger condition, see here.

But first I would like to clarify the diff between your setup (getting two builds) and my setup (getting only one build)

from jenkins-library.

CCFenner avatar CCFenner commented on August 29, 2024

Here is the job link.

from jenkins-library.

marcusholl avatar marcusholl commented on August 29, 2024

For your PR we have two build

  • one build (the "pr" build) builds the merge commit between github/master and the HEAD of the PR branch.
  • one build (the "push" build) builds the HEAD of the PR branch.

For my PRs I get only the "pr" build.

IMO the "pr" build is the interesting one, since this build reflects what happens if the PR would be merged. The "push" build is more the less nice to have.

I see one difference in our working mode. Your PR is based on a PR-branch located in SAP/jenkins-library. My PR is located in marcusholl/jenkins-library.

When I have time I will setup the travis build for my repo and try to introduce the ifcondition. Something like if: "${TRAVIS_PULL_REQUEST}" != "false" .

from jenkins-library.

CCFenner avatar CCFenner commented on August 29, 2024

This is what I meant, the branch is located in this repo and therefore receives a branch job. I think we should limit these branch jobs to master.

from jenkins-library.

marcusholl avatar marcusholl commented on August 29, 2024

I not convinced master in not a cool solution. We are interested in all branch which are bound to a pull request.

As already outlined above, what about: if: "${TRAVIS_PULL_REQUEST}" != "false"? Regarding TRAVIS_PULL_REQUEST see here.

from jenkins-library.

marcusholl avatar marcusholl commented on August 29, 2024

fix with #245

from jenkins-library.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.