Comments (9)
albertmink
commented on June 11, 2024
The feature is there. The squash/rebase culture not yet.
from abap-file-formats.
larshp
commented on June 11, 2024
by updating the repo settings, everything will be squashed. Squashing might not be optimal in all cases, but its good to have as the single allowed merge strategy
from abap-file-formats.
larshp
commented on June 11, 2024
also, keep branches up to date before merging, something like below,
from abap-file-formats.
albertmink
commented on June 11, 2024
yeah, let's setup some rules to have a clean commit history, that invites devs to look at. Admin @schneidermic0 can you configure the repo as suggested above?
from abap-file-formats.
schneidermic0
commented on June 11, 2024
I have changed the settings as suggested above
from abap-file-formats.
larshp
commented on June 11, 2024
Branch protection missing? Should see something like
from abap-file-formats.
schneidermic0
commented on June 11, 2024
I have just seen it...
from abap-file-formats.
schneidermic0
commented on June 11, 2024
Branch protection has been setup as well, now. Maybe, I have to slightly change it for the JSON validation, tomorrow.
I have also added that a review is required by at least one person.
from abap-file-formats.
larshp
commented on June 11, 2024
cool, looks good to me, closing, we can update the settings if something needs updating
from abap-file-formats.
Related Issues (20)
- Allow validation of JSON examples for `formatVersion != 1` HOT 6
- Validation of JSON data for multiple formatVersions
- Enum values for `abapLanguageVersion` are not documented HOT 1
- Could you please define format for TTYP (Tabletypes)? HOT 3
- GitHub Action "Validate JSON schema / validate (pull_request)" seems to be broken HOT 3
- please avoid some special characters in file names HOT 5
- DOMA feedback HOT 4
- [CHKV] Wrong parameter length in CHKV HOT 2
- [COTA] Add example HOT 1
- One of Mutliple Fields is Required HOT 1
- Could you please define format for DTEL (Data Element)? HOT 4
- [ILMB] Add example
- DMON + NONT + RONT doesnt have title + description in generated schema HOT 3
- use `.acds` extension for DDL? HOT 8
- ISO 639-1 is not sufficient for language fields HOT 11
- Translation and the need of a format version
- Q: enums with default being $required
- what are "ABAP repository objects"? HOT 5
- Improve markdown link check HOT 2
- Generate JSON Schema fails for version != 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from abap-file-formats.