Code Monkey home page Code Monkey logo

Comments (13)

schneidermic0 avatar schneidermic0 commented on June 11, 2024 1

As mentioned above all conversions in ABAP produce 2 characters upper case (e.g. ISOLA conversion exits or transformations):

I think I would prefer using ISO 639-1 using small characters.

However, I would like to check with the team how we can convert this fast in simple transformations.

from abap-file-formats.

schneidermic0 avatar schneidermic0 commented on June 11, 2024 1

I've looked through https://abapedia.org/steampunk-2111-api/ but did not find anything similar

Yes, there is nothing, currently. As mentioned above I sent the feedback to my colleagues. They've added it as request to their backlog.

from abap-file-formats.

larshp avatar larshp commented on June 11, 2024

still relevant, https://github.com/SAP/abap-file-formats/blob/main/file-formats/intf/examples/zif_aff_example.intf.json#L5

from abap-file-formats.

larshp avatar larshp commented on June 11, 2024

suggest following ISO standards

from abap-file-formats.

larshp avatar larshp commented on June 11, 2024

it's only possible for SAP to implement this issue, as the code for JSON generation is proprietary

from abap-file-formats.

larshp avatar larshp commented on June 11, 2024

I see this issue as an easy low hanging fruit, impacting all files in the project => ie. it should be high priority IMHO

from abap-file-formats.

schneidermic0 avatar schneidermic0 commented on June 11, 2024

We took this topic up. Unfortunately, it turned out, that ABAP uses always upper-case language codes.

Both accept lower case iso codes as input (in our case deserialisation) but produce uppercase codes as output (in our case during serialisation).

Even if I personally would prefer small characters for language codes, I think we should stick to the representation ABAP uses in other places, too.

If no one disagrees, we should specify this in our repository documentation.

from abap-file-formats.

larshp avatar larshp commented on June 11, 2024

suggest following ISO standards

from abap-file-formats.

schneidermic0 avatar schneidermic0 commented on June 11, 2024

Within the last weeks, we reiterated this topic (once more) and reached out to some more colleagues. They also suggested to use ISO-standard if the language is also used outside of ABAP systems.

Since I mentioned some ABAP functionality to do language conversions in ABAP systems. For the conversion to ISO language codes they suggested to use class CL_I18N_LANGUAGES.

We planned to take this up in our current iteration (see #280)

from abap-file-formats.

larshp avatar larshp commented on June 11, 2024

class CL_I18N_LANGUAGES is not released, I'd expect SAP to have released stuff to convert between internal format and ISO codes

from abap-file-formats.

schneidermic0 avatar schneidermic0 commented on June 11, 2024

class CL_I18N_LANGUAGES is not released, I'd expect SAP to have released stuff to convert between internal format and ISO codes

I have sent your feedback to the colleagues responsible.

from abap-file-formats.

larshp avatar larshp commented on June 11, 2024

I've looked through https://abapedia.org/steampunk-2111-api/ but did not find anything similar

from abap-file-formats.

schneidermic0 avatar schneidermic0 commented on June 11, 2024

I think we can close this issue. If I miss anything feel free to reopen it.

from abap-file-formats.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.