Comments (13)
As mentioned above all conversions in ABAP produce 2 characters upper case (e.g. ISOLA conversion exits or transformations):
- https://help.sap.com/doc/abapdocu_cp_index_htm/CLOUD/en-US/abenst_option_format.htm?file=abenst_option_format.htm#!ABAP_ADDITION_1@1@
- https://help.sap.com/doc/abapdocu_cp_index_htm/CLOUD/en-US/abenabap_xslt_asxml_schema.htm
I think I would prefer using ISO 639-1 using small characters.
However, I would like to check with the team how we can convert this fast in simple transformations.
from abap-file-formats.
I've looked through https://abapedia.org/steampunk-2111-api/ but did not find anything similar
Yes, there is nothing, currently. As mentioned above I sent the feedback to my colleagues. They've added it as request to their backlog.
from abap-file-formats.
still relevant, https://github.com/SAP/abap-file-formats/blob/main/file-formats/intf/examples/zif_aff_example.intf.json#L5
from abap-file-formats.
suggest following ISO standards
from abap-file-formats.
it's only possible for SAP to implement this issue, as the code for JSON generation is proprietary
from abap-file-formats.
I see this issue as an easy low hanging fruit, impacting all files in the project => ie. it should be high priority IMHO
from abap-file-formats.
We took this topic up. Unfortunately, it turned out, that ABAP uses always upper-case language codes.
- If we use the format option in transformations format
language
will be formatted as upper-case
see https://help.sap.com/doc/abapdocu_latest_index_htm/latest/en-US/index.htm - Even SAP's conversion exists for language fields (like the system language) convert the language to upper case.
see function modules CONVERSION_EXIT_ISOLA_* or CONVERT_SAP_LANG_TO_ISO_LANG
Both accept lower case iso codes as input (in our case deserialisation) but produce uppercase codes as output (in our case during serialisation).
Even if I personally would prefer small characters for language codes, I think we should stick to the representation ABAP uses in other places, too.
If no one disagrees, we should specify this in our repository documentation.
from abap-file-formats.
suggest following ISO standards
from abap-file-formats.
Within the last weeks, we reiterated this topic (once more) and reached out to some more colleagues. They also suggested to use ISO-standard if the language is also used outside of ABAP systems.
Since I mentioned some ABAP functionality to do language conversions in ABAP systems. For the conversion to ISO language codes they suggested to use class CL_I18N_LANGUAGES
.
We planned to take this up in our current iteration (see #280)
from abap-file-formats.
class CL_I18N_LANGUAGES
is not released, I'd expect SAP to have released stuff to convert between internal format and ISO codes
from abap-file-formats.
class CL_I18N_LANGUAGES is not released, I'd expect SAP to have released stuff to convert between internal format and ISO codes
I have sent your feedback to the colleagues responsible.
from abap-file-formats.
I've looked through https://abapedia.org/steampunk-2111-api/ but did not find anything similar
from abap-file-formats.
I think we can close this issue. If I miss anything feel free to reopen it.
from abap-file-formats.
Related Issues (20)
- Allow validation of JSON examples for `formatVersion != 1` HOT 6
- Validation of JSON data for multiple formatVersions
- Enum values for `abapLanguageVersion` are not documented HOT 1
- Could you please define format for TTYP (Tabletypes)? HOT 3
- GitHub Action "Validate JSON schema / validate (pull_request)" seems to be broken HOT 3
- please avoid some special characters in file names HOT 5
- DOMA feedback HOT 4
- [CHKV] Wrong parameter length in CHKV HOT 2
- [COTA] Add example HOT 1
- One of Mutliple Fields is Required HOT 1
- Could you please define format for DTEL (Data Element)? HOT 4
- [ILMB] Add example
- DMON + NONT + RONT doesnt have title + description in generated schema HOT 3
- use `.acds` extension for DDL? HOT 8
- ISO 639-1 is not sufficient for language fields HOT 11
- Translation and the need of a format version
- Q: enums with default being $required
- what are "ABAP repository objects"? HOT 5
- Improve markdown link check HOT 2
- Generate JSON Schema fails for version != 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from abap-file-formats.