sap_swpm: advanced mode inifile inorect build about community.sap_install HOT 5 CLOSED

@rhmk Thanks for reporting this. Here's my answer related to issue 2:
The current version contains a different code and already has:

when: not sap_swpm_product_catalog_id is defined

at the end of both tasks you have shown. So it appears that you are referring to an older version. See also #452 , #455, and https://github.com/sap-linuxlab/community.sap_install/pull/509/files#diff-f43020a778df24a123be473ace9b38f760f75e047872b1af08c4b1659a780607 .

from community.sap_install.

@rhmk Regarding issue 1: Can you please the show the code of task community.sap_install.sap_swpm : SAP SWPM - Detect FQDN here?
The output does not match the expected output of the current code of this task, the latter being:

awk '!/^#/&&/NW_getFQDN.FQDN/{print $3}' {{ sap_swpm_tmpdir.path }}/inifile.params

So we are looking for non-empty lines and in all lines which contain NW_getFQDN.FQDN, we are printing the 3rd column (white space delimited) of the line.

from community.sap_install.

For also catching lines which don't have spaces around =, we could use one of:

awk '!/^#/&&/NW_getFQDN.FQDN/{split ($0, a, "="); gsub (" ", "", a[2]); print a[2]}' inifile.params

or

awk '!/^#/&&/NW_getFQDN.FQDN/{gsub ("=", " = "); print $NF}' inifile.params

from community.sap_install.

But please note that we already have the condition:

when: not sap_swpm_fqdn is defined

so we first should check if this condition already catches all cases where the equals sign is not surrounded by spaces.

from community.sap_install.

I see that both issues seem to be fixed in current dev code, unfortunately I seem to have an issue with my git setup as this is not synced into my local copy, although I did a proper pull from upstream (probably not)

from community.sap_install.