Code Monkey home page Code Monkey logo

Comments (17)

LucasBrazi06 avatar LucasBrazi06 commented on September 15, 2024 1

1\ No, just rename the column which is not linked to the job imho. If you do a manual push you should also have a status here. In the end this is the last status of the last push whether it done by the job or manually.

2\ Ok, perfect.

3\ Ok.

from ev-dashboard.

LucasBrazi06 avatar LucasBrazi06 commented on September 15, 2024

In the list

  • Make the columns "Status" and "Update Job" centered (column and chip):

image

  • Create a new column between "Status" and "Update Job" named "Job Status" and add the same status than in the details (active/inactive).

  • Rename the column "Update Job" to "Last Job Exec"

In the details

  • Rename the column "Update Job" to "Job Status" and center it (column and chip)

  • Column "Total Charge-Point" is empty

image

  • Make Succeeded value green and Failed one red and why not in Chips?
    If you choose Chips, do it also for Total Charge Points in blue.

Thanks!

from ev-dashboard.

zulu06 avatar zulu06 commented on September 15, 2024

I've submitted a PR for the requested changes - here are 2 screenshots (english and french).

  • French version
    image

  • English version
    image

To my opinion, too much chips... the ui looks heavy now.

In addition with the new changes in the table design. Section seems to not be well delimited:
image

from ev-dashboard.

 avatar commented on September 15, 2024

from ev-dashboard.

zulu06 avatar zulu06 commented on September 15, 2024

With harmonized chip size - 8em for number and 10em for text - here below in french and english
image
image

Apres on peut essayer d'aligner les 2 groupes de chips (3) : meme taille - mais bon ils montrent pas la meme info.. a voir

PS: Drapeau bleu/blanc/rouge !!!! c'est limite du chauvinisme..

from ev-dashboard.

LucasBrazi06 avatar LucasBrazi06 commented on September 15, 2024

Vive la France :-) !!!

Je mettrai un min-width pour avoir ca au minimum :

image

Et un min-width pour les chiffres:

image

Si c'est plus grand, ca s'agrandira tout seul

from ev-dashboard.

LucasBrazi06 avatar LucasBrazi06 commented on September 15, 2024

Few remarks:

1\ If the Job is inactive, hide the column 'Last Exec Job'

2\ the 'Total Charge Point' value is not appearing

3\ Succeed/Failed chip size should be reduced as described in previous comment

image

from ev-dashboard.

zulu06 avatar zulu06 commented on September 15, 2024

Hi Serge,

for 1/ initially, there was a unique column with Job Status giving the last job exec and showing inactive if the job was inactive
i thought that the requested to add this additional column was to have the last job exec even if the job is inactive (you may still want to push manually the status) - hiding the column when inactive will remove the initial purpose of this additional column.

2/ Yes, the job has to run once to get the number of Total Charge Points (EVSE).

3/ the chip has a min-width that means it is resizing automatically to the width of the column. to have smaller chip i guess it is necessary to set the max-width or the width itself to a given size.

image
du coup il y a un min mais il s'agrandit tout seul :-)

from ev-dashboard.

LucasBrazi06 avatar LucasBrazi06 commented on September 15, 2024

1\ Then the column name is not adequate :-)
What about 'Last Push Status' then?

2\ You know in advance the number of charge points to push, it should be displayed right away.

3\ The Chip should fit on the figure inside, not the column width.

Thanks!

from ev-dashboard.

zulu06 avatar zulu06 commented on September 15, 2024

1/ this means go back to one column ?

2/ i only know the number of EVSE once going through the push process. Or this means i need to call the method who compute the number of EVSE once more (DB access) which at the end is unnecessary. The problem above is only a migration issue, will never append for new customer.

3/ i check what i can do.

from ev-dashboard.

zulu06 avatar zulu06 commented on September 15, 2024

J'ai ferme l'issue dans le vouloir :-( tu peux la re-ouvrir je vois pas l'option de mon cote

from ev-dashboard.

zulu06 avatar zulu06 commented on September 15, 2024

again 2 options:

  • uniform space between chips
    image

  • less space between columns
    image

by the way for 3/ if the chip rezise based on its content then different chip with different digit may be of different size.

from ev-dashboard.

LucasBrazi06 avatar LucasBrazi06 commented on September 15, 2024

I choose option 1 :-)

3\ Except if you set a min-width to fit 3 figures ;)

from ev-dashboard.

zulu06 avatar zulu06 commented on September 15, 2024

ok for option 1

for 3\ if the chip is based on the text content then chip could be with different size - so yes i have set a min-width and a max-width (otherwise it takes all the column size). Maybe i am not using the right css option. Do not see how it is possible at the same time to be content dependant and aware of the chip next to it (if the content size is different).

from ev-dashboard.

LucasBrazi06 avatar LucasBrazi06 commented on September 15, 2024

Demande aux pros des Chips Seb ou Florent

from ev-dashboard.

zulu06 avatar zulu06 commented on September 15, 2024

oui deja demande a Florent ce matin... j'ai cru comprendre que la seule solution était de monter une usine a gaz. Je vais soumettre deja la PR et on pourra en discuter Lundi, ca sera plus facile.

from ev-dashboard.

LucasBrazi06 avatar LucasBrazi06 commented on September 15, 2024

Perfect !!! 💯

from ev-dashboard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.