loopdiagram should give warning when if changes object names about eppy HOT 6 CLOSED

I think I've come across a better solution for this, and don't know why I didn't think of it before. Rather than replacing colons, we wrap every object name in double quotes. I'll have a look to see if there's an obvious place for this to happen.

See PyDot issue #28 and workaround.

from eppy.

I hand edited the Boiler.dot file and put the colons (:) back in. Then put double quotes around the strings. Looks like it will work.

from eppy.

OK. I think the simplest way to do this is to replace makeanode, makeabranch and makeendnode with the following:

def makeanode(name):
    name = escape_char(name, ':')
    return pydot.Node(name, shape="plaintext", label=name)

def makeabranch(name):
    name = escape_char(name, ':')
    return pydot.Node(name, shape="box3d", label=name)

def makeendnode(name):
    name = escape_char(name, ':')
    return pydot.Node(name, shape="doubleoctagon", label=name, 
        style="filled", fillcolor="#e4e4e4")

def escape_char(name, char):
    """escape strings which contain a specific character, char"""
    if char in name:
        return u"\"" + name + u"\""
    else:
        return name

For boiler.idf in resources\idffiles\V8_0_1 this produces the loop diagram attached which looks correct to me.

from eppy.

Can you make a branch i33_loopdiagram and push this code change in it.
I'll review and merge it develop (may happen after the license change release)

from eppy.

No problem. I've made the change in loopdiagram.py and in ex_loopdiagram.py too. Not sure which of those is current.

from eppy.

Jamie, I have merged this branch into develop
You have been added onto the copyright as follows

Copyright (c) 2015 Jamie Bull

Let me know if you need that updated (typos etc.)

from eppy.