Comments (6)
I think I've come across a better solution for this, and don't know why I didn't think of it before. Rather than replacing colons, we wrap every object name in double quotes. I'll have a look to see if there's an obvious place for this to happen.
See PyDot issue #28 and workaround.
from eppy.
I hand edited the Boiler.dot
file and put the colons (:) back in. Then put double quotes around the strings. Looks like it will work.
from eppy.
OK. I think the simplest way to do this is to replace makeanode
, makeabranch
and makeendnode
with the following:
def makeanode(name):
name = escape_char(name, ':')
return pydot.Node(name, shape="plaintext", label=name)
def makeabranch(name):
name = escape_char(name, ':')
return pydot.Node(name, shape="box3d", label=name)
def makeendnode(name):
name = escape_char(name, ':')
return pydot.Node(name, shape="doubleoctagon", label=name,
style="filled", fillcolor="#e4e4e4")
def escape_char(name, char):
"""escape strings which contain a specific character, char"""
if char in name:
return u"\"" + name + u"\""
else:
return name
For boiler.idf
in resources\idffiles\V8_0_1
this produces the loop diagram attached which looks correct to me.
from eppy.
Can you make a branch i33_loopdiagram
and push this code change in it.
I'll review and merge it develop (may happen after the license change release)
from eppy.
No problem. I've made the change in loopdiagram.py
and in ex_loopdiagram.py
too. Not sure which of those is current.
from eppy.
Jamie, I have merged this branch into develop
You have been added onto the copyright as follows
Copyright (c) 2015 Jamie Bull
Let me know if you need that updated (typos etc.)
from eppy.
Related Issues (20)
- eppy-core -- initial conda-forge support HOT 3
- create .readthedocs.yaml file
- Get idfobjects by regex HOT 5
- idf.run() not working on a mac for EnergyPlus-23-1-0
- Error when generating diagrams of HVAC loops HOT 1
- Error when running IDF(idfname) HOT 2
- make eplus_home configurable HOT 2
- use Github Actions for continuous integration HOT 1
- explore doing CI on two versions of E+
- Minor mistake on the documentation (Getting Started) HOT 10
- self installing jupyter notebook for eppy tutorial HOT 4
- Energyplus terminated and the program iteration stopped HOT 4
- Adding feature to change actuator values
- Suggestion: Add a “Getting Started” Section in README
- Is there an option for not converting numbers to numeric types when reading idfs? HOT 10
- Parsing issues when using older IDD files/specifying IDD files for use. HOT 17
- How to cite eppy? HOT 6
- in idf.getobject(key, name) key is case-sensitive. it should be case-insensitive HOT 1
- save E+ output as IDF HOT 10
- runIDFs() method suggestion HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eppy.