x11 is runtime dependency, not devDependency about node-ewmh HOT 16 CLOSED

actually, maybe not, since everything could be referenced from client parameter...

from node-ewmh.

In fact, I think I'll need that dependency as the eventMask is not referenced in the client or is it?

from node-ewmh.

It's not, but we can add it. What do you think?

from node-ewmh.

I think it makes sense.
Another thing that I think it could be somehow related is how do I make sure the client used by EWMH has a specific version. For example: I'm going to push some changes that needs the client to be from, at least, [email protected]
Is there a way to accomplish this? Ideally if this could be configured via package.json would be great

from node-ewmh.

peerDependency ?

from node-ewmh.

Oh, I didn't know about that. I'm going to check the npm docs.
Thanks!

BTW, don't worry about adding eventMask to the client. I'll do the PR

from node-ewmh.

I'm trying to keep everything in namespace objects but probably we can make exception for core events mask and alias them directly, so one could use X.PropertyNotify

from node-ewmh.

I'd rather do something like this: X.eventMask.PropertyNotify, so I know it is indeed a mask, but as you prefer

from node-ewmh.

Masks usually appear in big groups an I often see me typing 'eventMask' many times in the same expression

from node-ewmh.

Yes, I understand that. I'm not totally sold on this but will do.

from node-ewmh.

Maybe make eventMask hash and helper function? X.eventMask ('PropertyNotify StructureNotify)

from node-ewmh.

Ok expose only eventMask reference :)

from node-ewmh.

Sorry I'm not sure I understand:

X.PropertyNotify

or

X.eventMask.PropertyNotify

from node-ewmh.

The latter, as in your initial suggestion. I'm probably overcomplicating simple things. X.eventMask.PropertyNotify

from node-ewmh.

Ok. Thanks!

from node-ewmh.

Sent PR: sidorares/node-x11#43

from node-ewmh.